KAFKA-15568: Use IncrementalAlterConfigs API to update the dynamic config of broker in ConfigCommand tool #15590
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Use IncrementalAlterConfigs API to update the dynamic config of the broker in the ConfigCommand tool.
Why
As part of this KIP
incrementalAlterConfigs API
was introduced to change any config dynamically since the existingalterConfig API
replaces any existing configuration with new configuration. This makes AlterConfigs unusable in cases where the client does not know the full existing configuration before making the modification. Even worse, in some cases, the client may be unable to discover the existing configuration. "Sensitive" fields are not returned by DescribeConfigs.kakfa-config.sh (CommandConfig)
still usesalterConfig
to update the config.Testing
Updated existing test that will cover the cases.