-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-16737: Enable unit tests for new consumer & cleanup TODOs #16032
Conversation
Follow-up task KAFKA-16823 to refactor the test common functionality, and move out the unit tests that apply to the |
Hey @lucasbru , could you take a look at this small one when you have a chance? Thanks! --Edit-- |
Leaving as a draft for now as this seems to be affected by the timeout partial fix merged recently a98c9be. Will investigate and reopen this when ready. |
Hey @chia7712 , totally, I'll close this. It was only an initial exercise (helpful because it revealed bugs even though I didn't re-enabled the test that needed more work, I didn't have the bandwidth back then. Great that you and the other contributors could take on this! |
KafkaConsumerTest contained lots of unit tests that were not enabled for the new consumer, with TODOs for verifying if they could be enabled. This PR enables all the unit tests that could be applied to the new consumer, and cleans up the TODOs.
The tests that remain being applied to the legacy consumer only cannot run for the new consumer, due to: