KAFKA-17050: Revert group.version from 3.8 #16478
Conversation
This reverts commit 961c28a.
|
I will run the system tests with this solution as well. 👍 |
|
I looked at (I trust you on the import statement conflicts) :) One question, though, we are not setting |
|
@cmccabe Yeah, David and I had a discussion about the raftSupport. Until his change, we were always using the zk metadata cache. However, we are removing the metadata cache from those tests so I don't think it is a big deal. Or I guess to be clear -- we will want to eventually convert to all raft support, but reverting this now leaves us no worse off than before. some info: #16120 (comment) |
| @@ -246,8 +243,6 @@ public void testShortVersion() { | |||
| assertEquals("3.7", IBP_3_7_IV2.shortVersion()); | |||
| assertEquals("3.7", IBP_3_7_IV3.shortVersion()); | |||
| assertEquals("3.7", IBP_3_7_IV4.shortVersion()); | |||
| assertEquals("3.8", IBP_3_8_IV0.shortVersion()); | |||
There was a problem hiding this comment.
I guess that we can keep this assertEquals("3.8", IBP_3_8_IV0.shortVersion());?
There was a problem hiding this comment.
Hmm. It's strange that this was missing before. I can add it back.
jlprat
added
the
Blocker
|
@jolshan Are we going to hit the same issue with |
|
@dajac It is not a production feature so it is not supported by the brokers/controllers. |
|
Kraft upgrade system tests passed. Jenkins failures are unrelated. I will merge. |
|
Just kidding -- I missed @chia7712's comment. |
| @@ -62,6 +62,7 @@ abstract class IntegrationTestHarness extends KafkaServerTestHarness { | |||
| } | |||
|
|
|||
| override def generateConfigs: Seq[KafkaConfig] = { | |||
|
|
|||
There was a problem hiding this comment.
This wasn't done by me, it was something that David removed in his PR and I reverted it. But sure we can remove it.
| @@ -298,7 +298,7 @@ public void testFenceMultipleBrokers() throws Throwable { | |||
| new BrokerRegistrationRequestData(). | |||
| setBrokerId(brokerId). | |||
| setClusterId(active.clusterId()). | |||
| setFeatures(brokerFeatures(MetadataVersion.IBP_3_0_IV1, MetadataVersion.IBP_4_0_IV0)). | |||
| setFeatures(brokerFeatures(MetadataVersion.IBP_3_0_IV1, MetadataVersion.IBP_3_7_IV0)). | |||
There was a problem hiding this comment.
Hmm, should this be IBP_3_8_IV0?
| @@ -74,7 +74,7 @@ public void testDefaultFeatureMapWithUnstable() { | |||
| for (Features feature : Features.PRODUCTION_FEATURES) { | |||
| expectedFeatures.put(feature.featureName(), VersionRange.of( | |||
| 0, | |||
| feature.defaultValue(MetadataVersion.latestTesting()) | |||
| feature.defaultValue(MetadataVersion.LATEST_PRODUCTION) | |||
There was a problem hiding this comment.
Hmm, why is this changed to LATEST_PRODUCTION? The test is about unstable features.
|
My goal was to unblock the 3.8 release quickly so I didn't review every line of code I reverted. I can fix these things though. |
|
Nice -- green build for java 8! And the 3 failures for java 21 were unrelated. Merging now. Thanks all. |
Reverting due to complications when trying to fix KAFKA-17011 in 3.8. Now there will be no production features, so we won't send any over the wire in ApiVersions or BrokerRegistration and cause issues when the receiver is on an old version.
I reverted the typo PR to make the reverts cleaner and minimize chances for errors. The only conflicts were due to imports and a modified test testConsumerGroupDescribe. The fix was to keep the modified parameters but remove the metadataCache code.