KAFKA-16584: Make log processing summary configurable or debug--update upgrade-guide #16709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make log processing summary configurable or debug-- update upgrade-guide
3 tasks
bbejeck
reviewed
Aug 2, 2024
There was a problem hiding this comment.
Thanks @dujian0068 for the docs PR. Just one minor comment.
Also, there are conflicts can you rebase this PR?
docs/streams/upgrade-guide.html
Outdated
| <h3><a id="streams_api_changes_390" href="#streams_api_changes_390">Streams API changes in 3.9.0</a></h3> | ||
| <p> | ||
| Kafka Streams now supports users to customize the output interval of stream-thread runtime summary. | ||
| By default, the record is recorded every 2 minutes. More details can be found in |
There was a problem hiding this comment.
Suggested change
| By default, the record is recorded every 2 minutes. More details can be found in | |
| By default, it logs output every 2 minutes. More details can be found in |
There was a problem hiding this comment.
Thank you comment
I have made an update， and change the target branch to trunk
|
This PR should go against, |
Good catch, that's correct. |
Make log processing summary configurable or debug-- update upgrade-guide
Make log processing summary configurable or debug-- update upgrade-guide
|
This PR should add the new config also to |
mjsax
reviewed
Aug 5, 2024
docs/streams/upgrade-guide.html
Outdated
| @@ -152,6 +152,12 @@ <h3><a id="streams_api_changes_390" href="#streams_api_changes_390">Streams API | |||
| The specified handler must implement the <code>org.apache.kafka.streams.errors.ProcessingExceptionHandler</code> interface. | |||
| </p> | |||
|
|
|||
| <p> | |||
| Kafka Streams now supports users to customize the output interval of stream-thread runtime summary. | |||
There was a problem hiding this comment.
Suggested change
| Kafka Streams now supports users to customize the output interval of stream-thread runtime summary. | |
| Kafka Streams now allows to customize the logging interval of stream-thread runtime summary, via the newly added config <code>name of config which I don't know from top of my head :)</code>. |
There was a problem hiding this comment.
Thanks for your reply,
I have made the changes
mjsax
reviewed
Aug 5, 2024
docs/streams/upgrade-guide.html
Outdated
| @@ -152,6 +152,12 @@ <h3><a id="streams_api_changes_390" href="#streams_api_changes_390">Streams API | |||
| The specified handler must implement the <code>org.apache.kafka.streams.errors.ProcessingExceptionHandler</code> interface. | |||
| </p> | |||
|
|
|||
| <p> | |||
| Kafka Streams now supports users to customize the output interval of stream-thread runtime summary. | |||
| By default, it logs output every 2 minutes. More details can be found in | |||
There was a problem hiding this comment.
Suggested change
| By default, it logs output every 2 minutes. More details can be found in | |
| By default, the summary is logged every 2 minutes. More details can be found in |
There was a problem hiding this comment.
Thanks for your reply, I have made the changes
Make log processing summary configurable or debug-- update upgrade-guide
mjsax
changed the title
mjsax
pushed a commit
that referenced
this pull request
Aug 6, 2024
…e upgrade-guide (#16709) Updates Kafka Streams upgrade-guide for KIP-1049. Reviewers: Bill Bejeck <bill@confluent.io>, Matthias J. Sax <matthias@confluent.io>
|
Thank you! Merged to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KAFKA-16584 Make log processing summary configurable or debug
update upgrade-guide
Committer Checklist (excluded from commit message)