KAFKA-4826. Fix some findbugs warnings in Kafka Streams #2623
Conversation
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
| @@ -86,6 +86,8 @@ public boolean equals(final Object obj) { | |||
| if (obj == this) { | |||
| return true; | |||
| } | |||
| if (obj == null) | |||
| try { | ||
| this.db = openDB(this.dbDir, this.options, TTL_SECONDS); | ||
| } catch (IOException e) { | ||
| throw new KafkaException(e); |
|
@cmccabe Just in case you did not get the notifications.. |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
test this please. |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
| @@ -141,7 +144,11 @@ public void openDB(ProcessorContext context) { | |||
| valueSerde == null ? (Serde<V>) context.valueSerde() : valueSerde); | |||
|
|
|||
| this.dbDir = new File(new File(context.stateDir(), parentDir), this.name); | |||
| this.db = openDB(this.dbDir, this.options, TTL_SECONDS); | |||
| try { | |||
| this.db = openDB(this.dbDir, this.options, TTL_SECONDS); | |||
There was a problem hiding this comment.
Just for my own benefits: what's the advantage of using Files here, and in line 173 below?
There was a problem hiding this comment.
mvn, got some answers on SO..
No description provided.