-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-4826. Fix some findbugs warnings in Kafka Streams #2623
Conversation
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
@@ -86,6 +86,8 @@ public boolean equals(final Object obj) { | |||
if (obj == this) { | |||
return true; | |||
} | |||
if (obj == null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: add braces.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test to WindowTest
.
try { | ||
this.db = openDB(this.dbDir, this.options, TTL_SECONDS); | ||
} catch (IOException e) { | ||
throw new KafkaException(e); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be StreamsException
?
@cmccabe Just in case you did not get the notifications.. |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
test this please. |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
@@ -141,7 +144,11 @@ public void openDB(ProcessorContext context) { | |||
valueSerde == null ? (Serde<V>) context.valueSerde() : valueSerde); | |||
|
|||
this.dbDir = new File(new File(context.stateDir(), parentDir), this.name); | |||
this.db = openDB(this.dbDir, this.options, TTL_SECONDS); | |||
try { | |||
this.db = openDB(this.dbDir, this.options, TTL_SECONDS); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for my own benefits: what's the advantage of using Files
here, and in line 173 below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mvn, got some answers on SO..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merged to trunk. Thanks @cmccabe !!
No description provided.