New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-5063: Flaky ResetIntegrationTest #2931

Closed
wants to merge 3 commits into
base: trunk
from

Conversation

Projects
None yet
5 participants
@mjsax
Member

mjsax commented Apr 28, 2017

No description provided.

@mjsax

This comment has been minimized.

Show comment
Hide comment
@mjsax
Member

mjsax commented Apr 28, 2017

Call for review @enothereska @dguy @guozhangwang

@mjsax mjsax changed the title from KAFKA-5140: Flaky ResetIntegrationTest to KAFKA-5063: Flaky ResetIntegrationTest Apr 28, 2017

@asfbot

This comment has been minimized.

Show comment
Hide comment
@asfbot

asfbot Apr 28, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/3258/
Test PASSed (JDK 7 and Scala 2.10).

asfbot commented Apr 28, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/3258/
Test PASSed (JDK 7 and Scala 2.10).

@asfbot

This comment has been minimized.

Show comment
Hide comment
@asfbot

asfbot Apr 28, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/3263/
Test FAILed (JDK 8 and Scala 2.11).

asfbot commented Apr 28, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/3263/
Test FAILed (JDK 8 and Scala 2.11).

@asfbot

This comment has been minimized.

Show comment
Hide comment
@asfbot

asfbot Apr 28, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/3254/
Test PASSed (JDK 8 and Scala 2.12).

asfbot commented Apr 28, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/3254/
Test PASSed (JDK 8 and Scala 2.12).

@enothereska

This comment has been minimized.

Show comment
Hide comment
@enothereska

enothereska Apr 30, 2017

Contributor

I noticed one of the wait functions does not have the 60000 timeout.

Contributor

enothereska commented Apr 30, 2017

I noticed one of the wait functions does not have the 60000 timeout.

@enothereska

This comment has been minimized.

Show comment
Hide comment
@enothereska

enothereska Apr 30, 2017

Contributor

Also there is a test that failed, but it seems the results are not there anymore.

Contributor

enothereska commented Apr 30, 2017

Also there is a test that failed, but it seems the results are not there anymore.

@enothereska

This comment has been minimized.

Show comment
Hide comment
@enothereska

enothereska Apr 30, 2017

Contributor

retest this please

Contributor

enothereska commented Apr 30, 2017

retest this please

@asfbot

This comment has been minimized.

Show comment
Hide comment
@asfbot

asfbot Apr 30, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/3311/
Test FAILed (JDK 8 and Scala 2.11).

asfbot commented Apr 30, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/3311/
Test FAILed (JDK 8 and Scala 2.11).

@asfbot

This comment has been minimized.

Show comment
Hide comment
@asfbot

asfbot Apr 30, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/3306/
Test PASSed (JDK 7 and Scala 2.10).

asfbot commented Apr 30, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/3306/
Test PASSed (JDK 7 and Scala 2.10).

@asfbot

This comment has been minimized.

Show comment
Hide comment
@asfbot

asfbot Apr 30, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/3302/
Test FAILed (JDK 8 and Scala 2.12).

asfbot commented Apr 30, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/3302/
Test FAILed (JDK 8 and Scala 2.12).

@mjsax

This comment has been minimized.

Show comment
Hide comment
@mjsax

mjsax Apr 30, 2017

Member

About the timeout -- I guess we can got back to default anyway -- increasing the timeouts to 60000 was a try to stabilize the test -- it was not a proper fix though. WDTY about this?

Member

mjsax commented Apr 30, 2017

About the timeout -- I guess we can got back to default anyway -- increasing the timeouts to 60000 was a try to stabilize the test -- it was not a proper fix though. WDTY about this?

@asfbot

This comment has been minimized.

Show comment
Hide comment
@asfbot

asfbot Apr 30, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/3314/
Test PASSed (JDK 8 and Scala 2.11).

asfbot commented Apr 30, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/3314/
Test PASSed (JDK 8 and Scala 2.11).

@asfbot

This comment has been minimized.

Show comment
Hide comment
@asfbot

asfbot Apr 30, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/3309/
Test FAILed (JDK 7 and Scala 2.10).

asfbot commented Apr 30, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/3309/
Test FAILed (JDK 7 and Scala 2.10).

@asfbot

This comment has been minimized.

Show comment
Hide comment
@asfbot

asfbot Apr 30, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/3305/
Test PASSed (JDK 8 and Scala 2.12).

asfbot commented Apr 30, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/3305/
Test PASSed (JDK 8 and Scala 2.12).

@guozhangwang

This comment has been minimized.

Show comment
Hide comment
@guozhangwang

guozhangwang May 3, 2017

Contributor

Is this still needed?

Contributor

guozhangwang commented May 3, 2017

Is this still needed?

@guozhangwang

This comment has been minimized.

Show comment
Hide comment
@guozhangwang

guozhangwang May 3, 2017

Contributor

retest this please

Contributor

guozhangwang commented May 3, 2017

retest this please

@mjsax

This comment has been minimized.

Show comment
Hide comment
@mjsax

mjsax May 3, 2017

Member

I think yes -- the failure we observed is unrelated to the consumer reset strategy (cf https://github.com/apache/kafka/pull/2931/files#r114402394). The prefix did always match -- the test failed because different number of records got returned and thus the lists did not match because of different size.

Member

mjsax commented May 3, 2017

I think yes -- the failure we observed is unrelated to the consumer reset strategy (cf https://github.com/apache/kafka/pull/2931/files#r114402394). The prefix did always match -- the test failed because different number of records got returned and thus the lists did not match because of different size.

@asfbot

This comment has been minimized.

Show comment
Hide comment
@asfbot

asfbot May 3, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/3447/
Test PASSed (JDK 8 and Scala 2.11).

asfbot commented May 3, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/3447/
Test PASSed (JDK 8 and Scala 2.11).

@asfbot

This comment has been minimized.

Show comment
Hide comment
@asfbot

asfbot May 3, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/3440/
Test PASSed (JDK 8 and Scala 2.12).

asfbot commented May 3, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/3440/
Test PASSed (JDK 8 and Scala 2.12).

@asfbot

This comment has been minimized.

Show comment
Hide comment
@asfbot

asfbot May 3, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/3449/
Test PASSed (JDK 8 and Scala 2.11).

asfbot commented May 3, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/3449/
Test PASSed (JDK 8 and Scala 2.11).

@asfbot

This comment has been minimized.

Show comment
Hide comment
@asfbot

asfbot May 3, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/3443/
Test PASSed (JDK 7 and Scala 2.10).

asfbot commented May 3, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/3443/
Test PASSed (JDK 7 and Scala 2.10).

@mjsax

This comment has been minimized.

Show comment
Hide comment
@mjsax

mjsax May 9, 2017

Member

Updated this.

Member

mjsax commented May 9, 2017

Updated this.

@asfbot

This comment has been minimized.

Show comment
Hide comment
@asfbot

asfbot May 9, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/3668/
Test PASSed (JDK 8 and Scala 2.11).

asfbot commented May 9, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/3668/
Test PASSed (JDK 8 and Scala 2.11).

@asfbot

This comment has been minimized.

Show comment
Hide comment
@asfbot

asfbot May 9, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/3658/
Test FAILed (JDK 8 and Scala 2.12).

asfbot commented May 9, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/3658/
Test FAILed (JDK 8 and Scala 2.12).

@asfbot

This comment has been minimized.

Show comment
Hide comment
@asfbot

asfbot May 9, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/3662/
Test FAILed (JDK 7 and Scala 2.10).

asfbot commented May 9, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/3662/
Test FAILed (JDK 7 and Scala 2.10).

@mjsax

This comment has been minimized.

Show comment
Hide comment
@mjsax

mjsax May 9, 2017

Member

Retest this please.

Member

mjsax commented May 9, 2017

Retest this please.

@asfbot

This comment has been minimized.

Show comment
Hide comment
@asfbot

asfbot May 9, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/3671/
Test FAILed (JDK 8 and Scala 2.11).

asfbot commented May 9, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/3671/
Test FAILed (JDK 8 and Scala 2.11).

@asfbot

This comment has been minimized.

Show comment
Hide comment
@asfbot

asfbot May 9, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/3665/
Test FAILed (JDK 7 and Scala 2.10).

asfbot commented May 9, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/3665/
Test FAILed (JDK 7 and Scala 2.10).

@asfbot

This comment has been minimized.

Show comment
Hide comment
@asfbot

asfbot May 9, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/3661/
Test PASSed (JDK 8 and Scala 2.12).

asfbot commented May 9, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/3661/
Test PASSed (JDK 8 and Scala 2.12).

@mjsax

This comment has been minimized.

Show comment
Hide comment
@mjsax

mjsax May 9, 2017

Member

Retest this please

Member

mjsax commented May 9, 2017

Retest this please

@asfbot

This comment has been minimized.

Show comment
Hide comment
@asfbot

asfbot May 9, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/3667/
Test PASSed (JDK 7 and Scala 2.10).

asfbot commented May 9, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/3667/
Test PASSed (JDK 7 and Scala 2.10).

@asfbot

This comment has been minimized.

Show comment
Hide comment
@asfbot

asfbot May 9, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/3663/
Test FAILed (JDK 8 and Scala 2.12).

asfbot commented May 9, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/3663/
Test FAILed (JDK 8 and Scala 2.12).

@asfbot

This comment has been minimized.

Show comment
Hide comment
@asfbot

asfbot May 9, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/3673/
Test FAILed (JDK 8 and Scala 2.11).

asfbot commented May 9, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/3673/
Test FAILed (JDK 8 and Scala 2.11).

@guozhangwang

This comment has been minimized.

Show comment
Hide comment
@guozhangwang

guozhangwang May 9, 2017

Contributor

retest this please

Contributor

guozhangwang commented May 9, 2017

retest this please

@asfbot

This comment has been minimized.

Show comment
Hide comment
@asfbot

asfbot May 9, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/3689/
Test FAILed (JDK 8 and Scala 2.11).

asfbot commented May 9, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/3689/
Test FAILed (JDK 8 and Scala 2.11).

@asfbot

This comment has been minimized.

Show comment
Hide comment
@asfbot

asfbot May 9, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/3679/
Test FAILed (JDK 8 and Scala 2.12).

asfbot commented May 9, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/3679/
Test FAILed (JDK 8 and Scala 2.12).

@asfbot

This comment has been minimized.

Show comment
Hide comment
@asfbot

asfbot May 9, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/3683/
Test PASSed (JDK 7 and Scala 2.10).

asfbot commented May 9, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/3683/
Test PASSed (JDK 7 and Scala 2.10).

@guozhangwang

This comment has been minimized.

Show comment
Hide comment
@guozhangwang

guozhangwang May 9, 2017

Contributor

Created https://issues.apache.org/jira/browse/KAFKA-5209 for the newly observed transient failures.

Contributor

guozhangwang commented May 9, 2017

Created https://issues.apache.org/jira/browse/KAFKA-5209 for the newly observed transient failures.

@guozhangwang

Merged to trunk.

@asfgit asfgit closed this in 7371bf7 May 9, 2017

@mjsax mjsax deleted the mjsax:kafka-5140-flaky-reset-integration-test branch May 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment