Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-5171 : TC should not accept empty string transactional id #3086

Closed
wants to merge 1 commit into from
Closed

KAFKA-5171 : TC should not accept empty string transactional id #3086

wants to merge 1 commit into from

Conversation

umesh9794
Copy link
Contributor

@umesh9794 umesh9794 commented May 18, 2017 •
edited
Loading

This is a rebase version of PR#2973.

@guozhangwang , please review this updated PR.

@asfbot
Copy link

asfbot commented May 18, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/4121/
Test FAILed (JDK 8 and Scala 2.12).

@asfbot
Copy link

asfbot commented May 18, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/4134/
Test PASSed (JDK 7 and Scala 2.11).

@guozhangwang
Copy link
Contributor

LGTM. cc @hachikuji

hachikuji
hachikuji approved these changes May 18, 2017
View reviewed changes
Copy link

@hachikuji hachikuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the patch.

@asfgit asfgit closed this in 34e379f May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hachikuji hachikuji hachikuji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@umesh9794 @asfbot @guozhangwang @hachikuji