Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-5464: Follow up. Increase poll timeout #3496

Closed
wants to merge 1 commit into from
Closed

KAFKA-5464: Follow up. Increase poll timeout #3496

wants to merge 1 commit into from

Conversation

mjsax
Copy link
Member

@mjsax mjsax commented Jul 6, 2017

No description provided.

@mjsax mjsax mentioned this pull request Jul 6, 2017
Closed
@mjsax
Copy link
Member Author

mjsax commented Jul 6, 2017 •
edited

Compare: #3439 (comment)

\cc @ijuma @guozhangwang @dguy @enothereska @bbejeck

Needs to go into trunk, 0.11.0 and 0.10.2. Thx.

@asfgit
Copy link

asfgit commented Jul 6, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/5929/
Test PASSed (JDK 7 and Scala 2.11).

@asfgit
Copy link

asfgit commented Jul 6, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/5914/
Test PASSed (JDK 8 and Scala 2.12).

ijuma
ijuma approved these changes Jul 7, 2017
View reviewed changes
Copy link
Contributor

@ijuma ijuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. Are there any objections from the other reviewers?

dguy
dguy approved these changes Jul 7, 2017
View reviewed changes
Copy link
Contributor

@dguy dguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guozhangwang
Copy link
Contributor

LGTM.

asfgit pushed a commit that referenced this pull request Jul 7, 2017
@mjsax @guozhangwang
KAFKA-5464: Follow up. Increase poll timeout
3d72143 
Author: Matthias J. Sax <matthias@confluent.io>

Reviewers: Ismael Juma <ismael@juma.me.uk>, Damian Guy <damian.guy@gmail.com>, Guozhang Wang <wangguoz@gmail.com>

Closes #3496 from mjsax/KAFKA-5464-follow-up

(cherry picked from commit 35f9fa8)
Signed-off-by: Guozhang Wang <wangguoz@gmail.com>
asfgit pushed a commit that referenced this pull request Jul 7, 2017
@mjsax @guozhangwang
KAFKA-5464: Follow up. Increase poll timeout
fab7516 
Author: Matthias J. Sax <matthias@confluent.io>

Reviewers: Ismael Juma <ismael@juma.me.uk>, Damian Guy <damian.guy@gmail.com>, Guozhang Wang <wangguoz@gmail.com>

Closes #3496 from mjsax/KAFKA-5464-follow-up

(cherry picked from commit 35f9fa8)
Signed-off-by: Guozhang Wang <wangguoz@gmail.com>
@guozhangwang
Copy link
Contributor

Merged to trunk, 0.11.0, 0.10.2.

@asfgit asfgit closed this in 35f9fa8 Jul 7, 2017
@mjsax mjsax deleted the KAFKA-5464-follow-up branch July 7, 2017 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijuma ijuma ijuma approved these changes

@dguy dguy dguy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@mjsax @asfgit @guozhangwang @ijuma @dguy