KAFKA-5901: Added Connect metrics specific to source tasks #3959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedyu
reviewed
Sep 25, 2017
| + " must be greater than the minimum value " + min); | ||
| } | ||
| if (buckets < 1) { | ||
| throw new IllegalArgumentException("Must be at least 2 buckets"); |
There was a problem hiding this comment.
The message doesn't seem to match the condition above.
There was a problem hiding this comment.
Good catch. Will fix shortly.
|
Can you update the docs as well? docs/ops.html |
rhauch
changed the title
|
@wushujames, I'll follow up with the docs change in a separate PR. |
ewencp
reviewed
Sep 28, 2017
| private final Sensor pollTime; | ||
|
|
||
| public SourceTaskMetricsGroup(ConnectorTaskId id, ConnectMetrics connectMetrics) { | ||
| metricGroup = connectMetrics.group("source-tasks-metrics", |
There was a problem hiding this comment.
from the KIP, I think this is supposed to be source-task-metrics
|
Ok, based on ack, this LGTM and I'll just clean up that one extra |
asfgit
pushed a commit
that referenced
this pull request
Oct 3, 2017
Added Connect metrics specific to source tasks, and builds upon #3864 and #3911 that have already been merged into `trunk`, and #3959 that has yet to be merged. I'll rebase this PR when the latter is merged. Author: Randall Hauch <rhauch@gmail.com> Reviewers: Ewen Cheslack-Postava <ewen@confluent.io> Closes #3975 from rhauch/kafka-5902
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Connect metrics specific to source tasks, and builds upon #3864 and #3911 that have already been merged into
trunk.