KAFKA-5746; Return 0.0 from Metric.value() instead of throwing exception #3996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is less likely to break custom metric reporters and since the method is deprecated, people will be warned about this potential issue.
ewencp
approved these changes
Sep 29, 2017
|
Will merge to trunk after the build completes. |
xvrl
approved these changes
Sep 29, 2017
|
Tweaked the upgrade text a little and merged to trunk. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is less likely to break custom metric reporters and since the method
is deprecated, people will be warned about this potential issue.