KAFKA-6313: Add SLF4J as direct dependency to Kafka core #4296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijuma
approved these changes
Dec 7, 2017
There was a problem hiding this comment.
Thanks for the PR. #4297 fixes this in a nicer way, but we can merge this first since it's trivially correct. LGTM.
As an aside, I had assigned KAFKA-6313 to myself because I was working on it (even said so in the JIRA), so I was surprised to see this PR (and the ticket being reassigned). Let's avoid that in the future, please.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent changes are now directly using the SLF4J API, so we should have a direct dependency.
Committer Checklist (excluded from commit message)