-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-6536: Adding versions for japicmp-maven-plugin and maven-shade-plugin in #4569
Conversation
Retest this please. |
LGTM. |
do I need to look into this as some checks were not successful? |
@guozhangwang @bbejeck @dguy This error is strange
Any thoughts? @sawyna The failing tests seems to be unrelated to you change. I am going to re-trigger the tests. No action required from your side. Thx. |
Retest this please. |
\cc @bbejeck |
How did you pick the version numbers? Are those the latest versions? |
I have encountered it once a few weeks ago, but we did not change the rocksdb version or its impls recently, so that is indeed weird to me.. |
I've never seen this error, agreed it does not make sense. |
@mjsax Yes these are the latest versions. As the versions were missing, maven was automatically using the latest release versions which were not causing any issues. So I also put the same. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for clarifying @sawyna
LGTM.
…plugin in quickstart (#4569) Author: Yaswanth Kumar <yash27422@gmail.com> Reviewers: Guozhang Wang <guozhang@confluent.io>, Matthias J. Sax <matthias@confluent.io>
…plugin in quickstart (#4569) Author: Yaswanth Kumar <yash27422@gmail.com> Reviewers: Guozhang Wang <guozhang@confluent.io>, Matthias J. Sax <matthias@confluent.io>
…plugin in quickstart (#4569) Author: Yaswanth Kumar <yash27422@gmail.com> Reviewers: Guozhang Wang <guozhang@confluent.io>, Matthias J. Sax <matthias@confluent.io>
Merged to Thanks for the patch @sawyna ! |
Any suggestions on how to proceed with this error? Maybe just monitor and see if it happens again? Or should we create a JIRA as this seems to be the second time it happened? |
@mjsax I can try to reproduce next week while on-call. |
@mjsax Great! This is my first contribution to open source! |
quickstart
Added versions to japicmp-maven-plugin and maven-shade-plugin
in quickstart pom.xml. Previously these versions were missing and
the latest versions of the plugins were automatically being used.
I have explicitly set the version of each plugin to their latest.