Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-6536: Adding versions for japicmp-maven-plugin and maven-shade-plugin in #4569

Merged
merged 1 commit into from
Feb 16, 2018

Conversation

sawyna
Copy link
Contributor

@sawyna sawyna commented Feb 14, 2018

quickstart

Added versions to japicmp-maven-plugin and maven-shade-plugin
in quickstart pom.xml. Previously these versions were missing and
the latest versions of the plugins were automatically being used.
I have explicitly set the version of each plugin to their latest.

@mjsax
Copy link
Member

mjsax commented Feb 14, 2018

Retest this please.

@guozhangwang
Copy link
Contributor

LGTM.

@sawyna
Copy link
Contributor Author

sawyna commented Feb 15, 2018

do I need to look into this as some checks were not successful?

@mjsax
Copy link
Member

mjsax commented Feb 15, 2018

@guozhangwang @bbejeck @dguy This error is strange

java.lang.IllegalArgumentException: Illegal value provided for SubCode.
	at org.rocksdb.Status$SubCode.getSubCode(Status.java:109)
	at org.rocksdb.Status.<init>(Status.java:30)
	at org.rocksdb.RocksDB.put(Native Method)
	at org.rocksdb.RocksDB.put(RocksDB.java:488)
	at org.apache.kafka.streams.state.internals.RocksDBStore.putInternal(RocksDBStore.java:308)
	at org.apache.kafka.streams.state.internals.RocksDBStore.put(RocksDBStore.java:269)
	at org.apache.kafka.streams.state.internals.RocksDBStoreTest.shouldNotThrowExceptionOnRestoreWhenThereIsPreExistingRocksDbFiles(RocksDBStoreTest.java:91)

Any thoughts?

@sawyna The failing tests seems to be unrelated to you change. I am going to re-trigger the tests. No action required from your side. Thx.

@mjsax
Copy link
Member

mjsax commented Feb 15, 2018

Retest this please.

@mjsax mjsax changed the title Adding versions for japicmp-maven-plugin and maven-shade-plugin in KAFKA-6536: Adding versions for japicmp-maven-plugin and maven-shade-plugin in Feb 15, 2018
@mjsax mjsax added the streams label Feb 15, 2018
@mjsax
Copy link
Member

mjsax commented Feb 15, 2018

\cc @bbejeck

@mjsax
Copy link
Member

mjsax commented Feb 15, 2018

How did you pick the version numbers? Are those the latest versions?

@mjsax mjsax requested a review from dguy February 15, 2018 19:06
@mjsax mjsax unassigned dguy Feb 15, 2018
@guozhangwang
Copy link
Contributor

@guozhangwang @bbejeck @dguy This error is strange

I have encountered it once a few weeks ago, but we did not change the rocksdb version or its impls recently, so that is indeed weird to me..

@bbejeck
Copy link
Contributor

bbejeck commented Feb 15, 2018

I've never seen this error, agreed it does not make sense.

@sawyna
Copy link
Contributor Author

sawyna commented Feb 16, 2018

@mjsax Yes these are the latest versions. As the versions were missing, maven was automatically using the latest release versions which were not causing any issues. So I also put the same.

Copy link
Member

@mjsax mjsax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying @sawyna

LGTM.

@mjsax mjsax merged commit a2b6f66 into apache:trunk Feb 16, 2018
mjsax pushed a commit that referenced this pull request Feb 16, 2018
…plugin in quickstart (#4569)

Author: Yaswanth Kumar <yash27422@gmail.com>

Reviewers: Guozhang Wang <guozhang@confluent.io>, Matthias J. Sax <matthias@confluent.io>
mjsax pushed a commit that referenced this pull request Feb 16, 2018
…plugin in quickstart (#4569)

Author: Yaswanth Kumar <yash27422@gmail.com>

Reviewers: Guozhang Wang <guozhang@confluent.io>, Matthias J. Sax <matthias@confluent.io>
mjsax pushed a commit that referenced this pull request Feb 16, 2018
…plugin in quickstart (#4569)

Author: Yaswanth Kumar <yash27422@gmail.com>

Reviewers: Guozhang Wang <guozhang@confluent.io>, Matthias J. Sax <matthias@confluent.io>
@mjsax
Copy link
Member

mjsax commented Feb 16, 2018

Merged to trunk and cherry-picked to 1.1, 1.0, and 0.11.0 branches.

Thanks for the patch @sawyna !

@mjsax
Copy link
Member

mjsax commented Feb 16, 2018

@bbejeck @guozhangwang @dguy

Any suggestions on how to proceed with this error? Maybe just monitor and see if it happens again? Or should we create a JIRA as this seems to be the second time it happened?

@bbejeck
Copy link
Contributor

bbejeck commented Feb 17, 2018

@mjsax I can try to reproduce next week while on-call.

@sawyna
Copy link
Contributor Author

sawyna commented Feb 17, 2018

@mjsax Great! This is my first contribution to open source!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants