KAFKA-6592: Follow-up #4864
Merged
KAFKA-6592: Follow-up #4864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
ijuma
reviewed
Apr 29, 2018
| import scala.collection.JavaConversions._ | ||
| for (entry <- props) { | ||
| val key: String = entry._1 | ||
| val value: String = entry._2 |
There was a problem hiding this comment.
for ((key, value) <- props if key.startsWith(prefix) && key.length > prefix.length)
newProps.put(key.substring(prefix.length), value)Also, the method should be private and maybe it should be named propertiesWithKeyPrefixStripped or something.
There was a problem hiding this comment.
Ack, will do it as a hotfix commit.
jeqo
pushed a commit
to jeqo/kafka
that referenced
this pull request
May 2, 2018
Do not require ConsoleConsumer to specify inner serde as s special property, but just a normal property of the message formatter.
ying-zheng
pushed a commit
to ying-zheng/kafka
that referenced
this pull request
Jul 6, 2018
Do not require ConsoleConsumer to specify inner serde as s special property, but just a normal property of the message formatter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not require ConsoleConsumer to specify inner serde as s special property, but just a normal property of the message formatter.
Committer Checklist (excluded from commit message)