KAFKA-7111: Log error connecting to node at a higher log level #5312
Conversation
There were cases where the broker would return an unresolve-able address (e.g broker inside a docker network while client is outside) and the client would not log any information as to why it is timing out
There was a problem hiding this comment.
@stanislavkozlovski Thanks for the PR, LGTM. Merging to trunk and 2.0 since it helps diagnose configuration errors.
There are cases where the broker would return an unresolve-able address (e.g broker inside a docker network while client is outside) and the client would not log any information as to why it is timing out, since the default log level does not print DEBUG messages. Changing this log level will enable easier troubleshooting in such circumstances. This change does not change the logs shown on transient failures like a broker failure.
|
Can you please explain why this won't cause a lot of log spam if a broker is down? |
|
We had that in mind - my tests did not see this log be outputted in the scenario where a broker is down and the client is trying to connect |
|
@ijuma For async SocketChannel#connect, you are unlikely to see exceptions when initiating the connection unless the connection could not be initiated due to errors like unresolvable address. If the broker is down, we are more likely to see an exception when we invoke SocketChannel#finishConnect. In clients, we already log a warning without the exception stack trace for this case: |
…e#5312) There are cases where the broker would return an unresolve-able address (e.g broker inside a docker network while client is outside) and the client would not log any information as to why it is timing out, since the default log level does not print DEBUG messages. Changing this log level will enable easier troubleshooting in such circumstances. This change does not change the logs shown on transient failures like a broker failure.
There were cases where the broker would return an unresolve-able address (e.g broker inside a docker network while client is outside) and the client would not log any information as to why it is timing out, since the default log level does not print
DEBUGmessages.Changing this log level will enable easier troubleshooting in such circumstances. This change does not change the logs shown on transient failures like a broker failure, judging from my local tests.
Committer Checklist (excluded from commit message)