KAFKA-7152: Avoid moving a replica out of isr if its LEO equals leader's LEO #5412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lindong28 Could you help review this PR. Thanks! |
|
Thanks @hzxa21. It seems that the description of the PR is a bit confusing. This patch is typically useful when there are a large number of inactive partitions. But The change of this PR will take effect whether or not the partitions count per broker is relatively large. Can you update the description as appropriate? |
|
@lindong28 Thanks for pointing out. I have updated the description accordingly. |
lindong28
changed the title
|
@hzxa21 Thanks for the patch. LGTM. I made some change to the description. Merged to trunk. |
|
@lindong28 Thanks, Dong! |
|
Nice find! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are many inactive partitions in the cluster, we observed constant churn of URP in the cluster even if follower can catch up with leader's byte-in-rate because leader broker frequently moves replicas of inactive partitions out of ISR. This PR mitigates this issue by not moving replica out of ISR if follower's LEO == leader's LEO.
Committer Checklist (excluded from commit message)