Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-7269: Add docs for KStream.merge #5512

Merged
merged 1 commit into from
Aug 29, 2018
Merged

KAFKA-7269: Add docs for KStream.merge #5512

merged 1 commit into from
Aug 29, 2018

Conversation

lucapette
Copy link
Contributor

As discussed in KAFKA-7269

@lucapette
Copy link
Contributor Author

I just realized there's a typo in the PR. Will fix right away!

@lucapette
Copy link
Contributor Author

Just fixed it. It looks like this now:

screen shot 2018-08-16 at 07 27 59

Copy link
Member

@mjsax mjsax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mjsax
Copy link
Member

mjsax commented Aug 28, 2018

@guozhangwang @bbejeck @vvcephei Can we get a second pair of eyes looking at this. Thx.

@bbejeck
Copy link
Contributor

bbejeck commented Aug 28, 2018

retest this please

@guozhangwang guozhangwang merged commit 2514a42 into apache:trunk Aug 29, 2018
@guozhangwang
Copy link
Contributor

Thanks @lucapette for your contribution!

@lucapette
Copy link
Contributor Author

@guozhangwang thank you! very happy to contribute and hope to do more in the future!

pengxiaolong pushed a commit to pengxiaolong/kafka that referenced this pull request Jun 14, 2019
Matthias J. Sax <matthias@confluent.io>, Bill Bejeck <bill@confluent.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants