KAFKA-7715: Added a configuration parameter to Connect which disables WADL output for OPTIONS method. #6025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… WADL output for OPTIONS method.
rhauch
reviewed
Dec 13, 2018
| @@ -75,6 +75,9 @@ offset.flush.interval.ms=10000 | |||
| #rest.advertised.host.name= | |||
| #rest.advertised.port= | |||
|
|
|||
| # Controls presence of WADL information in a response to OPTIONS request | |||
| #rest.wadl.enable=false | |||
|
|
|||
There was a problem hiding this comment.
Do we also want to include this in the connect-standalone.properties?
There was a problem hiding this comment.
Good catch @rhauch , thanks. I've included new config into the standalone config file.
|
Closing this PR since related KIP was discarded. Will address it in https://issues.apache.org/jira/browse/KAFKA-7759. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Connect REST endpoint replies to
OPTIONSrequest with verbose WADL information, which could be used for an attack.It's not recommended for the production system to expose that information, but for the backward-compatibility reasons, it may still be available by default, with a possibility to turn it off by setting
rest.wadl.enable=false.Added unit tests in
RestServerTest, which asserts thatContent-typeis eitherapplication/vnd.sun.wadl+xmlifrest.wadl.enable=trueorrest.wadl.enableis not set; ortext/plainotherwise.Committer Checklist (excluded from commit message)