Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: Make info logs for KafkaConsumer a bit more verbose #6279

Merged
merged 3 commits into from Feb 17, 2019
Merged

MINOR: Make info logs for KafkaConsumer a bit more verbose #6279

merged 3 commits into from Feb 17, 2019

Conversation

ijuma
Copy link
Contributor

@ijuma ijuma commented Feb 16, 2019 •
edited

When debugging KafkaConsumer production issues, it's pretty
useful to have log entries related to seeking and committed
offset retrieval enabled by default. These are currently present,
but only when debug logging is enabled. Change them to info.

Also included a minor code simplication and a slight improvement
to an exception message.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@ijuma
MINOR: Make info logs for KafkaConsumer a bit more verbose
8331b45 
When debugging KafkaConsumer issues, it's pretty useful to
have some log entries that are only currently available when
debug logging is enabled.

Included a minor code simplication and a slight improvement to
an exception message.
@ijuma ijuma requested a review from hachikuji February 16, 2019 23:29
hachikuji
hachikuji reviewed Feb 17, 2019
View reviewed changes
Copy link
Contributor

@hachikuji hachikuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, makes sense to me. Just one comment.

clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java Show resolved Hide resolved
hachikuji
hachikuji approved these changes Feb 17, 2019
View reviewed changes
Copy link
Contributor

@hachikuji hachikuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@ijuma
Copy link
Contributor Author

ijuma commented Feb 17, 2019 •
edited

@mjsax you asked for build timeouts info:

04:44:33 org.apache.kafka.streams.scala.WordCountTest > testShouldCountWordsJava STARTED
04:44:46 Build timed out (after 240 minutes). Marking the build as aborted.

Other unrelated failure:

org.junit.runners.model.TestTimedOutException: test timed out after 120000 milliseconds
	at java.lang.Object.wait(Native Method)
	at java.lang.Object.wait(Object.java:502)
	at org.apache.kafka.common.internals.KafkaFutureImpl$SingleWaiter.await(KafkaFutureImpl.java:92)
	at org.apache.kafka.common.internals.KafkaFutureImpl.get(KafkaFutureImpl.java:260)
	at kafka.utils.TestUtils$.assertFutureExceptionTypeEquals(TestUtils.scala:1429)

@ijuma
Copy link
Contributor Author

ijuma commented Feb 17, 2019

retest this please

@ijuma
Copy link
Contributor Author

ijuma commented Feb 17, 2019

JDK 8 build passed, JDK 11 build failed with 2 known flaky tests. Since this PR doesn't change anything aside from strings, I will go ahead and merge it to trunk and the 2.2 branch.

@ijuma ijuma merged commit b53f844 into apache:trunk Feb 17, 2019
@ijuma ijuma deleted the kafka-consumer-logging-tweaks branch February 17, 2019 10:55
@mjsax
Copy link
Member

mjsax commented Feb 17, 2019

Thanks. Did you check if it was the related to https://issues.apache.org/jira/browse/KAFKA-7933 -- the copied logs don't help unfortunately.

jarekr pushed a commit to confluentinc/kafka that referenced this pull request Apr 18, 2019
@lbradstreet
Merge remote-tracking branch 'ak/trunk' into cos-trunk
0eacf48 
* ak/trunk: (45 commits)
  KAFKA-7487: DumpLogSegments misreports offset mismatches (apache#5756)
  MINOR: improve JavaDocs about auto-repartitioning in Streams DSL (apache#6269)
  KAFKA-7935: UNSUPPORTED_COMPRESSION_TYPE if ReplicaManager.getLogConfig returns None (apache#6274)
  KAFKA-7895: Fix stream-time reckoning for suppress (apache#6278)
  KAFKA-6569: Move OffsetIndex/TimeIndex logger to companion object  (apache#4586)
  MINOR: add log indicating the suppression time (apache#6260)
  MINOR: Make info logs for KafkaConsumer a bit more verbose (apache#6279)
  KAFKA-7758: Reuse KGroupedStream/KGroupedTable with named repartition topics (apache#6265)
  KAFKA-7884; Docs for message.format.version should display valid values (apache#6209)
  MINOR: Save failed test output to build output directory
  MINOR: add test for StreamsSmokeTestDriver (apache#6231)
  MINOR: Fix bugs identified by compiler warnings (apache#6258)
  KAFKA-6474: Rewrite tests to use new public TopologyTestDriver [part 4] (apache#5433)
  MINOR: fix bypasses in ChangeLogging stores (apache#6266)
  MINOR: Make MockClient#poll() more thread-safe (apache#5942)
  MINOR: drop dbAccessor reference on close (apache#6254)
  KAFKA-7811: Avoid unnecessary lock acquire when KafkaConsumer commits offsets (apache#6119)
  KAFKA-7916: Unify store wrapping code for clarity (apache#6255)
  MINOR: Add missing Alter Operation to Topic supported operations list in AclCommand
  KAFKA-7921: log at error level for missing source topic (apache#6262)
  ...
Pengxiaolong pushed a commit to Pengxiaolong/kafka that referenced this pull request Jun 14, 2019
@ijuma @Pengxiaolong
MINOR: Make info logs for KafkaConsumer a bit more verbose (apache#6279)
f54128d 
When debugging KafkaConsumer production issues, it's pretty
useful to have log entries related to seeking and committed
offset retrieval enabled by default. These are currently present,
but only when debug logging is enabled. Change them to `info`.

Also included a minor code simplication and a slight improvement
to an exception message.

Reviewers: Jason Gustafson <jason@confluent.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hachikuji hachikuji hachikuji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ijuma @mjsax @hachikuji