KAFKA-7312: Change broker port used in testMinimumRequestTimeouts and testForceClose #6360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omkreddy
commented
Mar 3, 2019
| @@ -1062,7 +1062,7 @@ class AdminClientIntegrationTest extends IntegrationTestHarness with Logging { | |||
| @Test | |||
| def testMinimumRequestTimeouts(): Unit = { | |||
| val config = createConfig() | |||
| config.put(AdminClientConfig.BOOTSTRAP_SERVERS_CONFIG, "localhost:22") | |||
There was a problem hiding this comment.
@ijuma Is there any specific reason for using port 22 (default SSH port) here? Due to this, some times the test is failing with out of memory .
java.lang.OutOfMemoryError: Java heap space
at java.nio.HeapByteBuffer.<init>(HeapByteBuffer.java:57)
at java.nio.ByteBuffer.allocate(ByteBuffer.java:335)
at org.apache.kafka.common.memory.MemoryPool$1.tryAllocate(MemoryPool.java:30)
at org.apache.kafka.common.network.NetworkReceive.readFrom(NetworkReceive.java:112)
at org.apache.kafka.common.network.KafkaChannel.receive(KafkaChannel.java:424)
at org.apache.kafka.common.network.KafkaChannel.read(KafkaChannel.java:385)
at org.apache.kafka.common.network.Selector.attemptRead(Selector.java:640)
at org.apache.kafka.common.network.Selector.pollSelectionKeys(Selector.java:561)
at org.apache.kafka.common.network.Selector.poll(Selector.java:472)
at org.apache.kafka.clients.NetworkClient.poll(NetworkClient.java:535)
at org.apache.kafka.clients.admin.KafkaAdminClient$AdminClientRunnable.run(KafkaAdminClient.java:1140)
at java.lang.Thread.run(Thread.java:748)
There was a problem hiding this comment.
That's weird, I don't know why that was chosen. Good find!
omkreddy
changed the title
ijuma
reviewed
Mar 3, 2019
…tMinimumRequestTimeouts, testForceClose) tests
|
@ijuma I have used port 225 as incorrect broker port. port 225 is a reserved port. Pls take a look. |
|
retest this please |
ijuma
reviewed
Mar 4, 2019
| @@ -71,6 +71,9 @@ object TestUtils extends Logging { | |||
| /* 0 gives a random port; you can then retrieve the assigned port from the Socket object. */ | |||
| val RandomPort = 0 | |||
|
|
|||
| /* Incorrect broker port which can used by kafka clients in tests. */ | |||
| val incorrectBrokerPort = 225 | |||
There was a problem hiding this comment.
Can we add something like: "this port should not be used by any other service and hence we use a reserved port"
ijuma
changed the title
ijuma
approved these changes
Mar 4, 2019
|
retest this please |
omkreddy
added a commit
that referenced
this pull request
Mar 4, 2019
… testForceClose Port 22 is used by ssh, which causes the AdminClient to throw an OOM: > java.lang.OutOfMemoryError: Java heap space > at java.nio.HeapByteBuffer.<init>(HeapByteBuffer.java:57) > at java.nio.ByteBuffer.allocate(ByteBuffer.java:335) > at org.apache.kafka.common.memory.MemoryPool$1.tryAllocate(MemoryPool.java:30) > at org.apache.kafka.common.network.NetworkReceive.readFrom(NetworkReceive.java:112) > at org.apache.kafka.common.network.KafkaChannel.receive(KafkaChannel.java:424) > at org.apache.kafka.common.network.KafkaChannel.read(KafkaChannel.java:385) > at org.apache.kafka.common.network.Selector.attemptRead(Selector.java:640) > at org.apache.kafka.common.network.Selector.pollSelectionKeys(Selector.java:561) > at org.apache.kafka.common.network.Selector.poll(Selector.java:472) > at org.apache.kafka.clients.NetworkClient.poll(NetworkClient.java:535) > at org.apache.kafka.clients.admin.KafkaAdminClient$AdminClientRunnable.run(KafkaAdminClient.java:1140) > at java.lang.Thread.run(Thread.java:748) > > Author: Manikumar Reddy <manikumar.reddy@gmail.com> Author: Ismael Juma <ismael@juma.me.uk> Reviewers: Ismael Juma <ismael@juma.me.uk> Closes #6360 from omkreddy/KAFKA-7312 (cherry picked from commit 9ee5f92) Signed-off-by: Manikumar Reddy <manikumar@confluent.io>
omkreddy
added a commit
that referenced
this pull request
Mar 4, 2019
… testForceClose Port 22 is used by ssh, which causes the AdminClient to throw an OOM: > java.lang.OutOfMemoryError: Java heap space > at java.nio.HeapByteBuffer.<init>(HeapByteBuffer.java:57) > at java.nio.ByteBuffer.allocate(ByteBuffer.java:335) > at org.apache.kafka.common.memory.MemoryPool$1.tryAllocate(MemoryPool.java:30) > at org.apache.kafka.common.network.NetworkReceive.readFrom(NetworkReceive.java:112) > at org.apache.kafka.common.network.KafkaChannel.receive(KafkaChannel.java:424) > at org.apache.kafka.common.network.KafkaChannel.read(KafkaChannel.java:385) > at org.apache.kafka.common.network.Selector.attemptRead(Selector.java:640) > at org.apache.kafka.common.network.Selector.pollSelectionKeys(Selector.java:561) > at org.apache.kafka.common.network.Selector.poll(Selector.java:472) > at org.apache.kafka.clients.NetworkClient.poll(NetworkClient.java:535) > at org.apache.kafka.clients.admin.KafkaAdminClient$AdminClientRunnable.run(KafkaAdminClient.java:1140) > at java.lang.Thread.run(Thread.java:748) > > Author: Manikumar Reddy <manikumar.reddy@gmail.com> Author: Ismael Juma <ismael@juma.me.uk> Reviewers: Ismael Juma <ismael@juma.me.uk> Closes #6360 from omkreddy/KAFKA-7312 (cherry picked from commit 9ee5f92) Signed-off-by: Manikumar Reddy <manikumar@confluent.io>
omkreddy
added a commit
that referenced
this pull request
Mar 4, 2019
… testForceClose Port 22 is used by ssh, which causes the AdminClient to throw an OOM: > java.lang.OutOfMemoryError: Java heap space > at java.nio.HeapByteBuffer.<init>(HeapByteBuffer.java:57) > at java.nio.ByteBuffer.allocate(ByteBuffer.java:335) > at org.apache.kafka.common.memory.MemoryPool$1.tryAllocate(MemoryPool.java:30) > at org.apache.kafka.common.network.NetworkReceive.readFrom(NetworkReceive.java:112) > at org.apache.kafka.common.network.KafkaChannel.receive(KafkaChannel.java:424) > at org.apache.kafka.common.network.KafkaChannel.read(KafkaChannel.java:385) > at org.apache.kafka.common.network.Selector.attemptRead(Selector.java:640) > at org.apache.kafka.common.network.Selector.pollSelectionKeys(Selector.java:561) > at org.apache.kafka.common.network.Selector.poll(Selector.java:472) > at org.apache.kafka.clients.NetworkClient.poll(NetworkClient.java:535) > at org.apache.kafka.clients.admin.KafkaAdminClient$AdminClientRunnable.run(KafkaAdminClient.java:1140) > at java.lang.Thread.run(Thread.java:748) > > Author: Manikumar Reddy <manikumar.reddy@gmail.com> Author: Ismael Juma <ismael@juma.me.uk> Reviewers: Ismael Juma <ismael@juma.me.uk> Closes #6360 from omkreddy/KAFKA-7312 (cherry picked from commit 9ee5f92) Signed-off-by: Manikumar Reddy <manikumar@confluent.io>
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
… testForceClose Port 22 is used by ssh, which causes the AdminClient to throw an OOM: > java.lang.OutOfMemoryError: Java heap space > at java.nio.HeapByteBuffer.<init>(HeapByteBuffer.java:57) > at java.nio.ByteBuffer.allocate(ByteBuffer.java:335) > at org.apache.kafka.common.memory.MemoryPool$1.tryAllocate(MemoryPool.java:30) > at org.apache.kafka.common.network.NetworkReceive.readFrom(NetworkReceive.java:112) > at org.apache.kafka.common.network.KafkaChannel.receive(KafkaChannel.java:424) > at org.apache.kafka.common.network.KafkaChannel.read(KafkaChannel.java:385) > at org.apache.kafka.common.network.Selector.attemptRead(Selector.java:640) > at org.apache.kafka.common.network.Selector.pollSelectionKeys(Selector.java:561) > at org.apache.kafka.common.network.Selector.poll(Selector.java:472) > at org.apache.kafka.clients.NetworkClient.poll(NetworkClient.java:535) > at org.apache.kafka.clients.admin.KafkaAdminClient$AdminClientRunnable.run(KafkaAdminClient.java:1140) > at java.lang.Thread.run(Thread.java:748) > > Author: Manikumar Reddy <manikumar.reddy@gmail.com> Author: Ismael Juma <ismael@juma.me.uk> Reviewers: Ismael Juma <ismael@juma.me.uk> Closes apache#6360 from omkreddy/KAFKA-7312
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port 22 is used by ssh, which causes the AdminClient to throw an OOM:
Committer Checklist (excluded from commit message)