KAFKA-7939: Fix timing issue in KafkaAdminClientTest.testCreateTopicsRetryBackoff #6418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a small timing window where |
rajinisivaram
approved these changes
Mar 11, 2019
There was a problem hiding this comment.
@omkreddy Thanks for the PR. Left one minor comment, apart from that LGTM.
| @@ -1261,6 +1261,11 @@ private static boolean groupIdIsUnrepresentable(String groupId) { | |||
| return groupId == null; | |||
| } | |||
|
|
|||
| //for testing | |||
| int noOfPendingCalls() { | |||
There was a problem hiding this comment.
Perhaps numPendingCalls is easier to read?
|
@rajinisivaram Thanks for the review. |
omkreddy
added a commit
that referenced
this pull request
Mar 11, 2019
…RetryBackoff There is a small timing window where ```time.sleep(retryBackoff)``` will get executed before adminClient adds retry request to the queue. Added a check to wait until the retry call added to the queue in AdminClient. Author: Manikumar Reddy <manikumar.reddy@gmail.com> Reviewers: Rajini Sivaram <rajinisivaram@googlemail.com> Closes #6418 from omkreddy/KAFKA-7939 (cherry picked from commit 173a7e3) Signed-off-by: Manikumar Reddy <manikumar@confluent.io>
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
…RetryBackoff There is a small timing window where ```time.sleep(retryBackoff)``` will get executed before adminClient adds retry request to the queue. Added a check to wait until the retry call added to the queue in AdminClient. Author: Manikumar Reddy <manikumar.reddy@gmail.com> Reviewers: Rajini Sivaram <rajinisivaram@googlemail.com> Closes apache#6418 from omkreddy/KAFKA-7939
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a small timing window where
time.sleep(retryBackoff)will get executed before adminClient adds retry request to the queue. Added a check to wait until the retry call added to the queue in AdminClient.Committer Checklist (excluded from commit message)