Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-8119; Ensure KafkaConfig listener accessors work during update #6457

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

rajinisivaram
Copy link
Contributor

Use the same config to obtain all properties used in each KafkaConfig accessor method to ensure that validation doesn't fail if config was updated during the method.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

Copy link
Contributor

@ijuma ijuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. This seems a little error prone. Can we use the type system to make it less so?

@ijuma
Copy link
Contributor

ijuma commented Dec 9, 2019

@rajinisivaram is this still relevant?

@rajinisivaram
Copy link
Contributor Author

I think this is probably still relevant in the case of DynamicBrokerReconfigurationTest. But that could probably be fixed in the test itself. Will take a look at test failures to see if we are running into the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants