KAFKA-8399: bring back internal.leave.group.on.close config for KStream #6779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abbccdda
force-pushed
the
back_leave_on_close
branch
from
3bd6cc6
to
3be5776
Compare
|
Retest this please |
|
Can we run the system tests (at least |
|
@abbccdda Made a pass, looks good overall. Could you also add back the unit test checking that upon shutting down Streams does not send leave group request as well, so that we can capture this earlier in unit tests than system tests? |
|
Second try passed too: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/2616/ |
|
retest this please |
|
Merged #6779 into trunk |
|
Cherry-picked to 2.3 as well. |
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
…am (apache#6779) As title states. We plan to merge this to both trunk and 2.3 if it could fix the stream system tests globally. Reference implementation: apache#6673 Reviewers: Guozhang Wang <wangguoz@gmail.com>, Matthias J. Sax <mjsax@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title states. We plan to merge this to both trunk and 2.3 if it could fix the stream system tests globally.
Reference implementation: #6673
Committer Checklist (excluded from commit message)