MINOR: Fix a toString npe in tableProcessorNode #6807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Worth adding a unit test. |
|
Fair enough |
rodesai
force-pushed
the
fix-npe-table-processor-node
branch
2 times, most recently
from
c12512e
to
fc7f17a
Compare
|
checkstyle seems not happy. |
|
Also, the target branch should be |
rodesai
force-pushed
the
fix-npe-table-processor-node
branch
from
fc7f17a
to
11e7518
Compare
|
JDK 11 build passed, JDK 8 build failed with flaky and unrelated |
ijuma
changed the title
ijuma
pushed a commit
that referenced
this pull request
May 25, 2019
This gets hit when debug logging is enabled. Reviewers: Bill Bejeck <bill@confluent.io>, Guozhang Wang <wangguoz@gmail.com>
|
Merged to trunk and 2.3 branches. |
haidangdam
pushed a commit
to haidangdam/kafka
that referenced
this pull request
May 29, 2019
This gets hit when debug logging is enabled. Reviewers: Bill Bejeck <bill@confluent.io>, Guozhang Wang <wangguoz@gmail.com>
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
This gets hit when debug logging is enabled. Reviewers: Bill Bejeck <bill@confluent.io>, Guozhang Wang <wangguoz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a toString npe in tableProcessorNode. This gets hit when we run
KSQL with debug logging enabled.