KAFKA-9192: fix NPE when for converting optional json schema in structs #7733
+10
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rhauch would appreciate a review! |
gharris1727
approved these changes
Feb 4, 2020
|
@levzem this looks great, but the Kafka project has all PRs against Can you please change the rebase your local branch on |
added 2 commits
February 11, 2020 19:30
Signed-off-by: Lev Zemlyanov <lev@confluent.io>
Signed-off-by: Lev Zemlyanov <lev@confluent.io>
|
ok to test |
rhauch
pushed a commit
that referenced
this pull request
Feb 12, 2020
…ts (#7733) Author: Lev Zemlyanov <lev@confluent.io> Reviewers: Greg Harris <gregh@confluent.io>, Randall Hauch <rhauch@gmail.com>
rhauch
pushed a commit
that referenced
this pull request
Feb 12, 2020
…ts (#7733) Author: Lev Zemlyanov <lev@confluent.io> Reviewers: Greg Harris <gregh@confluent.io>, Randall Hauch <rhauch@gmail.com>
rhauch
pushed a commit
that referenced
this pull request
Feb 12, 2020
…ts (#7733) Author: Lev Zemlyanov <lev@confluent.io> Reviewers: Greg Harris <gregh@confluent.io>, Randall Hauch <rhauch@gmail.com>
rhauch
pushed a commit
that referenced
this pull request
Feb 12, 2020
…ts (#7733) Author: Lev Zemlyanov <lev@confluent.io> Reviewers: Greg Harris <gregh@confluent.io>, Randall Hauch <rhauch@gmail.com>
stanislavkozlovski
pushed a commit
to stanislavkozlovski/kafka
that referenced
this pull request
Feb 18, 2020
…ts (apache#7733) Author: Lev Zemlyanov <lev@confluent.io> Reviewers: Greg Harris <gregh@confluent.io>, Randall Hauch <rhauch@gmail.com>
qq619618919
pushed a commit
to qq619618919/kafka
that referenced
this pull request
May 12, 2020
…ts (apache#7733) Author: Lev Zemlyanov <lev@confluent.io> Reviewers: Greg Harris <gregh@confluent.io>, Randall Hauch <rhauch@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves the bug https://issues.apache.org/jira/browse/KAFKA-9192
line #701 will throw a
NPEifjsonValueisnull, if the schema was optional and the field never existedSigned-off-by: Lev Zemlyanov lev@confluent.io
Committer Checklist (excluded from commit message)