KAFKA-9335: Fix StreamPartitionAssignor regression in repartition topics counts #7904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@guozhangwang @vvcephei @ableegoldman @bbejeck Ping for review |
|
retest this please |
guozhangwang
approved these changes
Jan 7, 2020
guozhangwang
pushed a commit
that referenced
this pull request
Jan 7, 2020
…ics counts (#7904) This PR fixes the regression introduced in 2.4 from 2 refactoring PRs: #7249 #7419 The bug was introduced by having a logical path leading numPartitionsCandidate to be 0, which is assigned to numPartitions and later being checked by setNumPartitions. In the subsequent check we will throw illegal argument if the numPartitions is 0. This bug is both impacting new 2.4 application and upgrades to 2.4 in certain types of topology. The example in original JIRA was imported as a new integration test to guard against such regression. We also verify that without the bug fix application will still fail by running this integration test. Reviewers: Guozhang Wang <wangguoz@gmail.com>
|
Cherry-picked to 2.4 |
guozhangwang
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Jan 7, 2020
…ics counts (apache#7904) This PR fixes the regression introduced in 2.4 from 2 refactoring PRs: apache#7249 apache#7419 The bug was introduced by having a logical path leading numPartitionsCandidate to be 0, which is assigned to numPartitions and later being checked by setNumPartitions. In the subsequent check we will throw illegal argument if the numPartitions is 0. This bug is both impacting new 2.4 application and upgrades to 2.4 in certain types of topology. The example in original JIRA was imported as a new integration test to guard against such regression. We also verify that without the bug fix application will still fail by running this integration test. Reviewers: Guozhang Wang <wangguoz@gmail.com>
qq619618919
pushed a commit
to qq619618919/kafka
that referenced
this pull request
May 12, 2020
…ics counts (apache#7904) This PR fixes the regression introduced in 2.4 from 2 refactoring PRs: apache#7249 apache#7419 The bug was introduced by having a logical path leading numPartitionsCandidate to be 0, which is assigned to numPartitions and later being checked by setNumPartitions. In the subsequent check we will throw illegal argument if the numPartitions is 0. This bug is both impacting new 2.4 application and upgrades to 2.4 in certain types of topology. The example in original JIRA was imported as a new integration test to guard against such regression. We also verify that without the bug fix application will still fail by running this integration test. Reviewers: Guozhang Wang <wangguoz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the regression introduced in 2.4 from 2 refactoring PRs:
#7249
#7419
The bug was introduced by having a logical path leading
numPartitionsCandidateto be 0, which is assigned tonumPartitionsand later being checked bysetNumPartitions. In the subsequent check we will throw illegal argument if thenumPartitionsis 0.This bug is both impacting new 2.4 application and upgrades to 2.4 in certain types of topology. The example in original JIRA was imported as a new integration test to guard against such regression. We also verify that without the bug fix application will still fail by running this integration test.
Committer Checklist (excluded from commit message)