KAFKA-9392; Clarify deleteAcls javadoc and add test for create/delete timing #7956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
rajinisivaram
commented
Jan 17, 2020
| * returned {@link AclDeleteResult} indicates which ACLs were deleted.</li> | ||
| * <li>If the provided filters use other resource pattern types that perform a direct match, all matching ACLs | ||
| * from previously completed {@link #createAcls(AuthorizableRequestContext, List)} )} are guaranteed | ||
| * to be deleted.</li> |
There was a problem hiding this comment.
@ijuma I added these to the Authorizer API (hence Admin API as well). But I wasn't sure if we should leave it to the implementation instead - i.e. implementations may provider stronger or weaker guarantees. If so, this doc would move to AclAuthorizer. What do you think?
There was a problem hiding this comment.
I agree, maybe we can move this doc to AclAuthorizer. we can also mention here to refer implementation docs for concurrent update guarantees.
rajinisivaram
force-pushed
the
KAFKA-9392-deleteAcls
branch
from
e238706
to
12009eb
Compare
|
retest this please |
|
@omkreddy Maybe you can help review this. |
|
@rajinisivaram there are some conflicts. |
rajinisivaram
force-pushed
the
KAFKA-9392-deleteAcls
branch
from
12009eb
to
8b3fece
Compare
|
Thanks @ijuma , rebased on trunk. |
omkreddy
approved these changes
May 30, 2020
|
@omkreddy Thanks for the review. Moved the comment to AclAuthorizer. Merging to trunk. |
rajinisivaram
added a commit
that referenced
this pull request
Jun 1, 2020
… timing (#7956) Reviewers: Manikumar Reddy <manikumar.reddy@gmail.com>
ijuma
added a commit
to confluentinc/kafka
that referenced
this pull request
Jun 3, 2020
* apache-github/2.6: (32 commits) KAFKA-10083: fix failed testReassignmentWithRandomSubscriptionsAndChanges tests (apache#8786) KAFKA-9945: TopicCommand should support --if-exists and --if-not-exists when --bootstrap-server is used (apache#8737) KAFKA-9320: Enable TLSv1.3 by default (KIP-573) (apache#8695) KAFKA-10082: Fix the failed testMultiConsumerStickyAssignment (apache#8777) MINOR: Remove unused variable to fix spotBugs failure (apache#8779) MINOR: ChangelogReader should poll for duration 0 for standby restore (apache#8773) KAFKA-10030: Allow fetching a key from a single partition (apache#8706) Kafka-10064 Add documentation for KIP-571 (apache#8760) MINOR: Code cleanup and assertion message fixes in Connect integration tests (apache#8750) KAFKA-9987: optimize sticky assignment algorithm for same-subscription case (apache#8668) KAFKA-9392; Clarify deleteAcls javadoc and add test for create/delete timing (apache#7956) KAFKA-10074: Improve performance of `matchingAcls` (apache#8769) KAFKA-9494; Include additional metadata information in DescribeConfig response (KIP-569) (apache#8723) KAFKA-10056; Ensure consumer metadata contains new topics on subscription change (apache#8739) KAFKA-10029; Don't update completedReceives when channels are closed to avoid ConcurrentModificationException (apache#8705) KAFKA-10061; Fix flaky `ReassignPartitionsIntegrationTest.testCancellation` (apache#8749) KAFKA-9130; KIP-518 Allow listing consumer groups per state (apache#8238) KAFKA-9501: convert between active and standby without closing stores (apache#8248) MINOR: Relax Percentiles test (apache#8748) MINOR: regression test for task assignor config (apache#8743) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-on from PR #7911 to clarify the guarantee for deleteAcls and add a deterministic test to ensure we don't regress.
Committer Checklist (excluded from commit message)