KIP-569-KAFKA-9494: DescribeConfigsResponse - include additional metadata information #8723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srpanwar-confluent
changed the title
There was a problem hiding this comment.
@srpanwar-confluent Thanks for the PR, looks good. Left some comments.
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
Outdated
Show resolved
Hide resolved
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java
Show resolved
Hide resolved
| @@ -43,6 +43,7 @@ | |||
| private static final String RESOURCE_TYPE_KEY_NAME = "resource_type"; | |||
| private static final String RESOURCE_NAME_KEY_NAME = "resource_name"; | |||
| private static final String CONFIG_NAMES_KEY_NAME = "config_names"; | |||
| private static final String INCLUDE_DOCUMENTATION = "include_documentation"; | |||
There was a problem hiding this comment.
Can we switch over to using the generated DescribeConfigsRequestData class?
| @@ -56,6 +56,8 @@ | |||
| private static final String IS_SENSITIVE_KEY_NAME = "is_sensitive"; | |||
| private static final String IS_DEFAULT_KEY_NAME = "is_default"; | |||
| private static final String READ_ONLY_KEY_NAME = "read_only"; | |||
| private static final String CONFIG_VALUE_TYPE_KEY_NAME = "config_value_type"; | |||
| private static final String CONFIG_DOCUMENTATION_KEY_NAME = "config_documentation"; | |||
There was a problem hiding this comment.
Same as the request, can we switch over to the generated class?
clients/src/main/resources/common/message/DescribeConfigsRequest.json
Outdated
Show resolved
Hide resolved
|
ok to test |
srpanwar-confluent
force-pushed
the
KAFKA-9494-2
branch
from
3ef9b03
to
712c72e
Compare
|
retest this please |
There was a problem hiding this comment.
@srpanwar-confluent Thanks for the updates, left a few more minor comments, apart from that, looks good.
clients/src/main/java/org/apache/kafka/common/requests/DescribeConfigsResponse.java
Outdated
Show resolved
Hide resolved
clients/src/main/resources/common/message/DescribeConfigsResponse.json
Outdated
Show resolved
Hide resolved
clients/src/test/java/org/apache/kafka/clients/admin/ConfigTest.java
Outdated
Show resolved
Hide resolved
srpanwar-confluent
force-pushed
the
KAFKA-9494-2
branch
from
712c72e
to
124825b
Compare
clients/src/main/resources/common/message/DescribeConfigsResponse.json
Outdated
Show resolved
Hide resolved
srpanwar-confluent
force-pushed
the
KAFKA-9494-2
branch
from
124825b
to
395515c
Compare
|
retest this please |
|
Looks like the last PR build failed with checkstyle failures: https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/2602/ |
srpanwar-confluent
force-pushed
the
KAFKA-9494-2
branch
from
395515c
to
3c10407
Compare
rajinisivaram
approved these changes
May 29, 2020
|
retest this please |
|
Test failures not related, merging to trunk and 2.6. |
rajinisivaram
pushed a commit
that referenced
this pull request
May 29, 2020
… response (KIP-569) (#8723) Adds documentation and type of ConfigEntry in version 3 of DescribeConfigsResponse Reviewers: Rajini Sivaram <rajinisivaram@googlemail.com>
Kvicii
pushed a commit
to Kvicii/kafka
that referenced
this pull request
May 30, 2020
* 'trunk' of github.com:apache/kafka: (36 commits) Remove redundant `containsKey` call in KafkaProducer (apache#8761) KAFKA-9494; Include additional metadata information in DescribeConfig response (KIP-569) (apache#8723) KAFKA-10061; Fix flaky `ReassignPartitionsIntegrationTest.testCancellation` (apache#8749) KAFKA-9130; KIP-518 Allow listing consumer groups per state (apache#8238) KAFKA-9501: convert between active and standby without closing stores (apache#8248) KAFKA-10056; Ensure consumer metadata contains new topics on subscription change (apache#8739) MINOR: Log the reason for coordinator discovery failure (apache#8747) KAFKA-10029; Don't update completedReceives when channels are closed to avoid ConcurrentModificationException (apache#8705) MINOR: remove unnecessary timeout for admin request (apache#8738) MINOR: Relax Percentiles test (apache#8748) MINOR: regression test for task assignor config (apache#8743) MINOR: Update documentation.html to refer to 2.6 (apache#8745) MINOR: Update documentation.html to refer to 2.5 (apache#8744) KAFKA-9673: Filter and Conditional SMTs (apache#8699) KAFKA-9971: Error Reporting in Sink Connectors (KIP-610) (apache#8720) KAFKA-10052: Harden assertion of topic settings in Connect integration tests (apache#8735) MINOR: Slight MetadataCache tweaks to avoid unnecessary work (apache#8728) KAFKA-9802; Increase transaction timeout in system tests to reduce flakiness (apache#8736) KAFKA-10050: kafka_log4j_appender.py fixed for JDK11 (apache#8731) KAFKA-9146: Add option to force delete active members in StreamsResetter (apache#8589) ... # Conflicts: # core/src/main/scala/kafka/log/Log.scala
ijuma
added a commit
to confluentinc/kafka
that referenced
this pull request
Jun 3, 2020
* apache-github/2.6: (32 commits) KAFKA-10083: fix failed testReassignmentWithRandomSubscriptionsAndChanges tests (apache#8786) KAFKA-9945: TopicCommand should support --if-exists and --if-not-exists when --bootstrap-server is used (apache#8737) KAFKA-9320: Enable TLSv1.3 by default (KIP-573) (apache#8695) KAFKA-10082: Fix the failed testMultiConsumerStickyAssignment (apache#8777) MINOR: Remove unused variable to fix spotBugs failure (apache#8779) MINOR: ChangelogReader should poll for duration 0 for standby restore (apache#8773) KAFKA-10030: Allow fetching a key from a single partition (apache#8706) Kafka-10064 Add documentation for KIP-571 (apache#8760) MINOR: Code cleanup and assertion message fixes in Connect integration tests (apache#8750) KAFKA-9987: optimize sticky assignment algorithm for same-subscription case (apache#8668) KAFKA-9392; Clarify deleteAcls javadoc and add test for create/delete timing (apache#7956) KAFKA-10074: Improve performance of `matchingAcls` (apache#8769) KAFKA-9494; Include additional metadata information in DescribeConfig response (KIP-569) (apache#8723) KAFKA-10056; Ensure consumer metadata contains new topics on subscription change (apache#8739) KAFKA-10029; Don't update completedReceives when channels are closed to avoid ConcurrentModificationException (apache#8705) KAFKA-10061; Fix flaky `ReassignPartitionsIntegrationTest.testCancellation` (apache#8749) KAFKA-9130; KIP-518 Allow listing consumer groups per state (apache#8238) KAFKA-9501: convert between active and standby without closing stores (apache#8248) MINOR: Relax Percentiles test (apache#8748) MINOR: regression test for task assignor config (apache#8743) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements KIP-569
Adds
documentationandtypeofConfigEntryin version 3 ofDescribeConfigsResponseCommitter Checklist (excluded from commit message)