-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KAFKA-9563] Fix Kafka connect consumer and producer override docs #8124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @blcksrx !
Indeed this paragraph needs improvement and the producer.override.
and consumer.override.
prefixes are missing. But the replacement is not at the right place. The global prefixes producer.
and consumer.
can still be used in the workers configuration.
I added a suggested change to your one line change. Lmk what you think
Co-Authored-By: Konstantine Karantasis <konstantine@confluent.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix and the quick turnaround @blcksrx !
LGTM
ok to test |
The builder failed with the known broken test This is a documentation only improvement, so based on this run I'm merging this PR. |
…cer overrides (#8124) Kafka Connect main doc required a fix to distinguish between worker level producer and consumer overrides and per-connector level producer and consumer overrides, after the latter were introduced with KIP-458. * [KAFKA-9563] Fix Kafka connect consumer and producer override documentation Co-authored-by: Konstantine Karantasis <konstantine@confluent.io> Reviewers: Konstantine Karantasis <konstantine@confluent.io>
…cer overrides (#8124) Kafka Connect main doc required a fix to distinguish between worker level producer and consumer overrides and per-connector level producer and consumer overrides, after the latter were introduced with KIP-458. * [KAFKA-9563] Fix Kafka connect consumer and producer override documentation Co-authored-by: Konstantine Karantasis <konstantine@confluent.io> Reviewers: Konstantine Karantasis <konstantine@confluent.io>
…cer overrides (#8124) Kafka Connect main doc required a fix to distinguish between worker level producer and consumer overrides and per-connector level producer and consumer overrides, after the latter were introduced with KIP-458. * [KAFKA-9563] Fix Kafka connect consumer and producer override documentation Co-authored-by: Konstantine Karantasis <konstantine@confluent.io> Reviewers: Konstantine Karantasis <konstantine@confluent.io>
…cer overrides (apache#8124) Kafka Connect main doc required a fix to distinguish between worker level producer and consumer overrides and per-connector level producer and consumer overrides, after the latter were introduced with KIP-458. * [KAFKA-9563] Fix Kafka connect consumer and producer override documentation Co-authored-by: Konstantine Karantasis <konstantine@confluent.io> Reviewers: Konstantine Karantasis <konstantine@confluent.io>
The true parameters for overriding producer config or consumer config in Kafka-Connect are
producer.override.[PRODUCER-CONFIG]
orconsumer.override.[CONSUMER-CONFIG]
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)