KAFKA-9742: Fix StandbyTaskEOSIntegrationTest End offset #8329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test this please |
|
LGTM. |
3 tasks
chia7712
reviewed
Mar 23, 2020
| @@ -120,7 +120,7 @@ private KafkaStreams buildStreamWithDirtyStateDir(final String appId, | |||
| new StreamsConfig(props), new MockTime(), true); | |||
|
|
|||
| new OffsetCheckpoint(new File(stateDirectory.directoryForTask(taskId), ".checkpoint")) | |||
| .write(Collections.singletonMap(new TopicPartition("unknown-topic", 0), 5L)); | |||
| .write(Collections.singletonMap(new TopicPartition("unknown-topic", 0), 0L)); | |||
There was a problem hiding this comment.
this offset is added deliberately so as to make task corrupted.
|
seems #8330 is going to fix this flaky. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
StandbyTaskEOSIntegrationTestwas broken due to the incorrect offset setting in the checkpoint file enforced by 6cf27c9. The fix is to set the offset to a legitimate value even if the topic doesn't exist.Committer Checklist (excluded from commit message)