KAFKA-9605: Do not attempt to abort batches when txn manager is in fatal error #8177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit db81ce6.
abbccdda
changed the title
|
@bob-barrett @hachikuji Could you take a look when you got time? |
|
ok to test |
bob-barrett
approved these changes
Mar 2, 2020
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java
Outdated
Show resolved
Hide resolved
| handleProduceResponse(response, recordsByPartition, time.milliseconds()); | ||
| } | ||
| }; | ||
| RequestCompletionHandler callback = response -> handleProduceResponse(response, recordsByPartition, time.milliseconds()); |
|
Thanks @bob-barrett ! Note that we got 1/2 green build already. |
|
test this please |
hachikuji
approved these changes
Mar 11, 2020
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We detected a bug in soak where the producer batches shall be failed in sender loop before the produce response callback. This shall trigger an illegal state exception on the producer batch as it is already aborted.
The impact is not severe since sender is on its own thread but should be fixed to avoid unnecessary critical exception.
Committer Checklist (excluded from commit message)