Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-9866: Avoid election for topics where preferred leader is not in ISR #8524

Merged
merged 6 commits into from
Apr 27, 2020
Merged

KAFKA-9866: Avoid election for topics where preferred leader is not in ISR #8524

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
44eea04
Avoid starting election for topics where preferred leader is not in s…
leonardge Apr 21, 2020
29632f7
Refactored the code and fixed bug in the integration test.
leonardge Apr 22, 2020
172960f
Refactored according to comments.
leonardge Apr 23, 2020
24c6d42
Kept the code to be consistent.
leonardge Apr 24, 2020
dc67b99
Reverted style change.
leonardge Apr 24, 2020
2fa3cee
Renamed helper function after review.
leonardge Apr 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core/src/main/scala/kafka/controller/KafkaController.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1066,6 +1066,7 @@ class KafkaController(val config: KafkaConfig,
// do this check only if the broker is live and there are no partitions being reassigned currently
// and preferred replica election is not in progress
val candidatePartitions = topicsNotInPreferredReplica.keys.filter(tp => controllerContext.isReplicaOnline(leaderBroker, tp) &&
controllerContext.partitionLeadershipInfo(tp).leaderAndIsr.isr.contains(leaderBroker) &&
leonardge marked this conversation as resolved.
Show resolved Hide resolved
controllerContext.partitionsBeingReassigned.isEmpty &&
!topicDeletionManager.isTopicQueuedUpForDeletion(tp.topic) &&
controllerContext.allTopics.contains(tp.topic))
Expand Down