MINOR; Move quota integration tests to using the new quota API. #8954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ijuma @rajinisivaram Could you review this one when you have time? |
rajinisivaram
approved these changes
Jul 20, 2020
There was a problem hiding this comment.
@dajac Thanks for the PR. Left one minor comment, apart from that LGTM.
| props.put(DynamicConfig.Client.ConsumerByteRateOverrideProp, consumerQuota.toString) | ||
| props.put(DynamicConfig.Client.RequestPercentageOverrideProp, requestQuota.toString) | ||
| props | ||
| // Default is set by using Some(null) for either or both user and clientId |
There was a problem hiding this comment.
Maybe add a constant for the default entity and use Some(DefaultEntity) which would avoid the need for the comment that sounds like we are doing something we shouldn't be.
|
@rajinisivaram Thanks for the review. I just pushed an updated that addressed your comment. |
|
ok to test |
|
Connect test failure unrelated, merging to trunk. |
gitlw
pushed a commit
to linkedin/kafka
that referenced
this pull request
Sep 9, 2021
…ng the new quota API. (apache#8954) Reviewers: Rajini Sivaram <rajinisivaram@googlemail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the various quota integration tests in the
kafka.apipackage and migrates them to using the new quota API instead of writing the quota to ZK directly.Committer Checklist (excluded from commit message)