KAFKA-10308 fix flaky core/round_trip_fault_test.py #9079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
the failed test is unrelated to this PR. retest this please |
|
@ijuma Could you please take a look? |
|
ok to test |
ijuma
pushed a commit
that referenced
this pull request
Aug 4, 2020
Creating a topic may fail (due to timeout) in running system tests. However, `RoundTripWorker` does not ignore `TopicExistsException` which makes `round_trip_fault_test.py` be a flaky one. More specifically, a network exception can cause the `CreateTopics` request to reach Kafka but Trogdor retry it and hit a `TopicAlreadyExists` exception on the retry, failing the test. Reviewers: Ismael Juma <ismael@juma.me.uk>
|
@ijuma considering this is causing the system test to be flaky, is it worth backporting? It seems like the test is present since 1.1 |
ijuma
pushed a commit
that referenced
this pull request
Aug 20, 2020
Creating a topic may fail (due to timeout) in running system tests. However, `RoundTripWorker` does not ignore `TopicExistsException` which makes `round_trip_fault_test.py` be a flaky one. More specifically, a network exception can cause the `CreateTopics` request to reach Kafka but Trogdor retry it and hit a `TopicAlreadyExists` exception on the retry, failing the test. Reviewers: Ismael Juma <ismael@juma.me.uk>
ijuma
pushed a commit
that referenced
this pull request
Aug 20, 2020
Creating a topic may fail (due to timeout) in running system tests. However, `RoundTripWorker` does not ignore `TopicExistsException` which makes `round_trip_fault_test.py` be a flaky one. More specifically, a network exception can cause the `CreateTopics` request to reach Kafka but Trogdor retry it and hit a `TopicAlreadyExists` exception on the retry, failing the test. Reviewers: Ismael Juma <ismael@juma.me.uk>
ijuma
pushed a commit
that referenced
this pull request
Aug 20, 2020
Creating a topic may fail (due to timeout) in running system tests. However, `RoundTripWorker` does not ignore `TopicExistsException` which makes `round_trip_fault_test.py` be a flaky one. More specifically, a network exception can cause the `CreateTopics` request to reach Kafka but Trogdor retry it and hit a `TopicAlreadyExists` exception on the retry, failing the test. Reviewers: Ismael Juma <ismael@juma.me.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a topic may fail (due to timeout) in running system tests. However,
RoundTripWorkerdoes not ignoreTopicExistsExceptionwhich makesround_trip_fault_test.pybe a flaky one.More specifically, a network exception can cause the CreateTopics request to reach Kafka but Trogdor retry it
and hit a TopicAlreadyExists exception on the retry, failing the test.
Committer Checklist (excluded from commit message)