Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-10386; Fix flexible version support for records type #9163

Merged
merged 3 commits into from
Aug 13, 2020

Conversation

hachikuji
Copy link
Contributor

This patch fixes the generated serde logic for the 'records' type so that it uses the compact byte array representation consistently when flexible versions are enabled.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

Copy link
Contributor

@mumrah mumrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hachikuji hachikuji force-pushed the fix-records-flexible-generation branch from 12ecaa1 to 7d0d12d Compare August 12, 2020 23:53
@hachikuji
Copy link
Contributor Author

retest this please

1 similar comment
@hachikuji
Copy link
Contributor Author

retest this please

@hachikuji
Copy link
Contributor Author

Previous builds appear to have succeeded, but I might have jumped the gun on the retest. For example: https://builds.apache.org/job/kafka-pr-jdk11-scala2.13/7820/

@hachikuji hachikuji merged commit 3a189ad into apache:trunk Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants