Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to add redis-cli to the docker image so that it can be downloaded and used immediately. #1376

Open
2 tasks done
KeeProMise opened this issue Apr 9, 2023 · 4 comments
Labels
enhancement type enhancement

Comments

@KeeProMise
Copy link
Member

Search before asking

  • I had searched in the issues and found no similar issues.

Motivation

I downloaded docker Mirror, found that you need to install redis-cli yourself,s it possible to add redis-cli to the docker image so that it can be downloaded and used immediately.

Solution

No response

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@KeeProMise KeeProMise added the enhancement type enhancement label Apr 9, 2023
@git-hulk
Copy link
Member

git-hulk commented Apr 9, 2023

This sounds good to me. cc @torwig @PragmaTwice @ShooterIT

@PragmaTwice
Copy link
Member

PragmaTwice commented Apr 9, 2023

I do not think it is necessary. The docker image we provide is only for starting a kvrocks service, not a redis client.

You can build a docker image only for redis-cli, find one in the docker hub, or use redis-cli in your host environment.

BTW, we do not encourage anyone to modify the entrypoint of the docker image and use other binaries in the image. It is literally only for one binary, i.e. bin/kvrocks.

@KeeProMise
Copy link
Member Author

We don't need to modify the entrypoint, I think redis-cli can be added to the bin directory, so that for some people who are new to the database, it is very convenient (enter the docker container to run bin/redis-cli) to execute some redis commands to interact with the database. Moreover, the same is true for mysql, redis, iotdb, etc. that I know.

@PragmaTwice
Copy link
Member

PragmaTwice commented Apr 10, 2023

When you "enter" the docker container via shell (docker exec), you changed the entrypoint of the docker image from bin/kvrocks to bash (or the posix shell, whatever).

We do not expect users to do this.

Another thing is that, seems there is no package in ubuntu for a single redis-cli.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement type enhancement
Projects
None yet
Development

No branches or pull requests

3 participants