Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the performance benchmark to website #2294

Closed
1 of 2 tasks
PragmaTwice opened this issue May 6, 2024 · 3 comments · Fixed by #2299
Closed
1 of 2 tasks

Move the performance benchmark to website #2294

PragmaTwice opened this issue May 6, 2024 · 3 comments · Fixed by #2299
Assignees
Labels
enhancement type enhancement

Comments

@PragmaTwice
Copy link
Member

Search before asking

  • I had searched in the issues and found no similar issues.

Motivation

It does not need to be shown in README. Just a link is enough.

Also, if there's no reproduce script for it, I think we can just delete them.

Solution

No response

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@suxb201
Copy link

suxb201 commented May 27, 2024

@git-hulk I couldn't find the benchmark on the website, even though you've removed it from the README.md.

@git-hulk
Copy link
Member

@suxb201 Yes, the reason is the benchmark result cannot be reproduced by users, so remove it first to avoid confusing users.

@PragmaTwice
Copy link
Member Author

PragmaTwice commented May 30, 2024

It is not because the current performance is lower than the benchmark result, just we cannot find the benchmark script, so we decide to remove it.

We can add a reproducible benchmark script and also a benchmark post to our website later.

Anyway welcome to do benchmark by yourself and share with us. @suxb201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement type enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants