[KYUUBI #670] KyuubiSQLException support sqlState and errorCode #674
Conversation
Codecov Report
@@ Coverage Diff @@
## master #674 +/- ##
==========================================
+ Coverage 80.10% 80.41% +0.30%
==========================================
Files 120 120
Lines 4709 4717 +8
Branches 572 573 +1
==========================================
+ Hits 3772 3793 +21
+ Misses 611 601 -10
+ Partials 326 323 -3
Continue to review full report at Codecov.
|
kyuubi-common/src/main/scala/org/apache/kyuubi/KyuubiSQLException.scala
Outdated
Show resolved
Hide resolved
kyuubi-common/src/main/scala/org/apache/kyuubi/KyuubiException.scala
Outdated
Show resolved
Hide resolved
| * (which is saved for later retrieval by the `getCause()` method); | ||
| * may be null indicating the cause is non-existent or unknown. | ||
| */ | ||
| class KyuubiSQLException(msg: String, cause: Throwable, sqlState: String, errorCode: Int) |
There was a problem hiding this comment.
the constructor paras order is not the same with SQLException and the comment
| def apply(msg: String, | ||
| cause: Throwable = null, | ||
| sqlState: String = null, | ||
| errorCode: Int = 0): KyuubiSQLException = { |
There was a problem hiding this comment.
maybe venderCode is more accurate?
| msg: String, | ||
| cause: Throwable = null, | ||
| sqlState: String = null, | ||
| vendorCode: Int = 0): KyuubiSQLException = { |
There was a problem hiding this comment.
reorder the parameters to simplify method overwrite
pan3793
changed the title
| msg: String, | ||
| cause: Throwable = null, | ||
| sqlState: String = null, | ||
| vendorCode: Int = 0): KyuubiSQLException = { |
There was a problem hiding this comment.
vendorCode: Int = 0
Why we use 0 as the default code, seems 0 is success. use -1 ?
There was a problem hiding this comment.
nvm, SQLException also use 0 ..
|
thanks, merging to master for v1.3.0 |
Why are the changes needed?
#670
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request