Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Umbrella] Support SQLSTATE and venderCode in KyuubiSQLException #670

Open
1 of 2 tasks
yaooqinn opened this issue Jun 8, 2021 · 1 comment
Open
1 of 2 tasks

Comments

@yaooqinn
Copy link
Member

yaooqinn commented Jun 8, 2021

1. Describe the feature

https://www.postgresql.org/docs/12/errcodes-appendix.html
https://docs.oracle.com/cd/E15817_01/appdev.111/b31228/appd.htm
https://www.ibm.com/docs/en/db2-for-zos/11?topic=codes-sqlstate-values-common-error
https://en.wikipedia.org/wiki/SQLSTATE
https://wiki.midrange.com/index.php/SQLSTATE_Codes
https://docs.teradata.com/r/CeAGk~BNtx~axcR0ed~5kw/TONkXZQG19hcmPLSw~O36w

2. Motivation

3. Describe the solution

We can make KyuubiSQLException inherit

public SQLException(String reason, String sqlState, int vendorCode, Throwable cause) first.

4. Additional context

@yaooqinn
Copy link
Member Author

track apache/spark#32850

ulysses-you pushed a commit that referenced this issue Jul 5, 2021
<!--
Thanks for sending a pull request!

Here are some tips for you:
  1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
  2. If the PR is related to an issue in https://github.com/NetEase/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
  3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->

### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
  1. If you add a feature, you can talk about the use case of it.
  2. If you fix a bug, you can clarify why it is a bug.
-->
Follow #670 to:
Apply errorCode 0A000: feature_not_supported to val errStatus = KyuubiSQLException("Feature is not  available").toTStatus

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/tools/testing.html#running-tests) locally before make a pull request

Closes #729 from zhaomin1423/728.

Closes #728

396e70d [Min Zhao] update FrontendServiceSuite to adapt KyuubiSQLException.featureNotSupported
c06dbfd [Min Zhao] invoke KyuubiSQLException.featureNotSupported() in FrontendService
281aed9 [Min Zhao] add featureNotSupported to KyuubiSQLException object

Authored-by: Min Zhao <zhaomin1423@163.com>
Signed-off-by: ulysses-you <ulyssesyou18@gmail.com>
@yaooqinn yaooqinn changed the title Support SQLSTATE and venderCode in KyuubiSQLException [Umbrella] Support SQLSTATE and venderCode in KyuubiSQLException Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant