-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove storage and volume interface implementation #1972
chore: Remove storage and volume interface implementation #1972
Conversation
c9fada1
to
86ff77e
Compare
Reviewer note: The Elastic Block storage feature was removed from Equinix Metal in June 2021. |
@Kami is this something that you can review and merge? There are three Equinix Metal PRs up. I have reviewed them on their Equinix Metal merits. |
Thanks for the contribution. Since this is a breaking change, can you please add an entry in upgrade notes file (docs/upgrade_notes.rst)? Thanks. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## trunk #1972 +/- ##
==========================================
+ Coverage 83.20% 83.25% +0.06%
==========================================
Files 353 353
Lines 81423 81252 -171
Branches 8591 8559 -32
==========================================
- Hits 67742 67645 -97
+ Misses 10874 10820 -54
+ Partials 2807 2787 -20
|
@aayushrangwala Can you please sync up this branch with a latest trunk? I wanted to wrap it up myself locally, but I noticed more work is needed to make this change complete - it appears Please let me know when that has been addressed and when all checks are passing and I will have a look again. On that note, it would also be good to update PR description with some context and why this change is needed (I know that context may be available in other PR, but we should also update this PR description). Thanks. |
Signed-off-by: Ayush Rangwala <ayush.rangwala@gmail.com>
86ff77e
to
e8786ee
Compare
@Kami can you please review again, Ive rebased and updated. |
@@ -570,6 +511,8 @@ def _metal_v1_storage_attachments_2c16a96f_bb4f_471b_8e2e_b5820b9e1603( | |||
if method == "DELETE": | |||
return (httplib.NO_CONTENT, "", {}, httplib.responses[httplib.NO_CONTENT]) | |||
|
|||
======= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merge conflict should be cleaned up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved
Signed-off-by: Ayush Rangwala <ayush.rangwala@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removals look right.
@antoinebourayne I had a look and it looks like this comment is still relevant - #1972 (comment) I see |
Changes Title (replace this with a logical title for your changes)
Remove unused and unsupported apis from equinix metal
Description
For more information on contributing, please see Contributing
section of our documentation.
Status
Ready For Review
Checklist (tick everything that applies)