Issue: LIBCLOUD-466 Add ingress/egress VPC support to security group rul... #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if cidr_ips is not None: | ||
| i = 1 | ||
| ip_ranges = {} | ||
| for cidr_ip in cidr_ips: |
There was a problem hiding this comment.
You could get rid of two lines if you use enumerate which is considered more "Pythonic".
So something like:
for index, cidr_ip in enumerate(cidr_ips, 1)
...There was a problem hiding this comment.
Nice call. I will make that change momentarily.
Added additional documentation for user/group pairs.
|
While merging and testing the patch, I have noticed a test failure under Python 2.5. I have forgot that I've fixed that, squashed the commits and merged patch into trunk. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...es