Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: LIBCLOUD-466 Add ingress/egress VPC support to security group rul... #202

Closed
wants to merge 2 commits into from
Closed

Issue: LIBCLOUD-466 Add ingress/egress VPC support to security group rul... #202

wants to merge 2 commits into from

Conversation

cderamus
Copy link
Contributor

...es

if cidr_ips is not None:
i = 1
ip_ranges = {}
for cidr_ip in cidr_ips:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could get rid of two lines if you use enumerate which is considered more "Pythonic".

So something like:

for index, cidr_ip in enumerate(cidr_ips, 1)
...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice call. I will make that change momentarily.

Added additional documentation for user/group pairs.
@Kami
Copy link
Member

Kami commented Dec 21, 2013

While merging and testing the patch, I have noticed a test failure under Python 2.5. I have forgot that enumerate function in 2.5 doesn't support start argument.

I've fixed that, squashed the commits and merged patch into trunk.

Thanks!

@cderamus cderamus closed this Dec 22, 2013
@cderamus cderamus deleted the LIBCLOUD-466_Add_VPC_Ingress_Egress_Rules branch December 22, 2013 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants