New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Cloud DNS #378

Closed
wants to merge 4 commits into
base: trunk
from

Conversation

Projects
None yet
3 participants
@fcuny
Contributor

fcuny commented Oct 20, 2014

This CL fix a couple of bugs for the Google Cloud DNS' API, and handle the error code 'alreadyExists' as a 'ResourceExistsError'.

cc @erjohnso

fcuny added some commits Oct 20, 2014

Support CONFLICT response for Google Cloud's API
If the status code for a call to the Google Cloud's API is 409 (CONFLICT), and
the code of the error is 'alreadyExists', consider the resource as already
existing and create the correct error.
The default ttl for Google Cloud's API is 0.
The default can't be `None' since we're calling `int' on the value of ttl.
@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami
Member

Kami commented Oct 21, 2014

@erjohnso

This comment has been minimized.

Show comment
Hide comment
@erjohnso

erjohnso Oct 21, 2014

Member

@franckcuny - thanks!
@Kami - LGTM

Member

erjohnso commented Oct 21, 2014

@franckcuny - thanks!
@Kami - LGTM

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Oct 23, 2014

Member

Merged into trunk.

Thanks.

Member

Kami commented Oct 23, 2014

Merged into trunk.

Thanks.

@asfgit asfgit closed this in 206a5b4 Oct 23, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment