Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIBCLOUD-745] Add Vultr DNS provider implementation #579

Closed

Conversation

@aleGpereira
Copy link
Contributor

@aleGpereira aleGpereira commented Sep 14, 2015

I have another provider to add. Thanks for your awesome work guys.

@aleGpereira aleGpereira force-pushed the aleGpereira:LIBCLOUD-745_vultr_provider branch 2 times, most recently from b0060a1 to 0382755 Sep 24, 2015
@aleGpereira aleGpereira force-pushed the aleGpereira:LIBCLOUD-745_vultr_provider branch from 0382755 to cd2684f Sep 25, 2015

return ret_record

def create_zone(self, zone_id, type='master', ttl=None, extra={}):

This comment has been minimized.

@Kami

Kami Sep 25, 2015
Member

Not a good idea to default to mutable types (dicts, lists), I will change it to default to None and do extra = extra or {} inside the method body when merging the PR.

@Kami
Copy link
Member

@Kami Kami commented Sep 25, 2015

Thanks for syncing the branch with latest trunk :)

@asfgit asfgit closed this in fd5827a Sep 25, 2015
@Kami
Copy link
Member

@Kami Kami commented Sep 25, 2015

Fixed minor Python 3 compatibility issue and merged patch into trunk. Thanks!

@aleGpereira aleGpereira deleted the aleGpereira:LIBCLOUD-745_vultr_provider branch Oct 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.