[LIBCLOUD-745] Add Vultr DNS provider implementation #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleGpereira
force-pushed
the
LIBCLOUD-745_vultr_provider
branch
2 times, most recently
from
b0060a1
to
0382755
Compare
aleGpereira
force-pushed
the
LIBCLOUD-745_vultr_provider
branch
from
0382755
to
cd2684f
Compare
|
|
||
| return ret_record | ||
|
|
||
| def create_zone(self, zone_id, type='master', ttl=None, extra={}): |
There was a problem hiding this comment.
Not a good idea to default to mutable types (dicts, lists), I will change it to default to None and do extra = extra or {} inside the method body when merging the PR.
|
Thanks for syncing the branch with latest trunk :) |
|
Fixed minor Python 3 compatibility issue and merged patch into trunk. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have another provider to add. Thanks for your awesome work guys.