New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIBCLOUD-745] Add Vultr DNS provider implementation #579

Closed
wants to merge 1 commit into
base: trunk
from

Conversation

Projects
None yet
3 participants
@aleGpereira
Contributor

aleGpereira commented Sep 14, 2015

I have another provider to add. Thanks for your awesome work guys.

return ret_record
def create_zone(self, zone_id, type='master', ttl=None, extra={}):

This comment has been minimized.

@Kami

Kami Sep 25, 2015

Member

Not a good idea to default to mutable types (dicts, lists), I will change it to default to None and do extra = extra or {} inside the method body when merging the PR.

@Kami

Kami Sep 25, 2015

Member

Not a good idea to default to mutable types (dicts, lists), I will change it to default to None and do extra = extra or {} inside the method body when merging the PR.

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Sep 25, 2015

Member

Thanks for syncing the branch with latest trunk :)

Member

Kami commented Sep 25, 2015

Thanks for syncing the branch with latest trunk :)

@asfgit asfgit closed this in fd5827a Sep 25, 2015

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Sep 25, 2015

Member

Fixed minor Python 3 compatibility issue and merged patch into trunk. Thanks!

Member

Kami commented Sep 25, 2015

Fixed minor Python 3 compatibility issue and merged patch into trunk. Thanks!

@aleGpereira aleGpereira deleted the aleGpereira:LIBCLOUD-745_vultr_provider branch Oct 12, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment