t2.nano instance for ec2 #663

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@tonybaloney
Contributor

tonybaloney commented Dec 21, 2015

No description provided.

@asfgit asfgit closed this in f856da9 Dec 21, 2015

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Dec 22, 2015

Member

I just noticed you didn't update region details dict - https://github.com/DimensionDataCBUSydney/libcloud/blob/1273eacf5a89547354ececf447a7684b0db38f2a/libcloud/compute/drivers/ec2.py#L647

If you don't update that, user won't be able to use this new instance type (size). You need to update region details entry for each region where this instance type is now available (you will also need to update affected tests).

Member

Kami commented Dec 22, 2015

I just noticed you didn't update region details dict - https://github.com/DimensionDataCBUSydney/libcloud/blob/1273eacf5a89547354ececf447a7684b0db38f2a/libcloud/compute/drivers/ec2.py#L647

If you don't update that, user won't be able to use this new instance type (size). You need to update region details entry for each region where this instance type is now available (you will also need to update affected tests).

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Dec 22, 2015

Member

And when you make that change, please also update changelog.

Member

Kami commented Dec 22, 2015

And when you make that change, please also update changelog.

@tonybaloney

This comment has been minimized.

Show comment
Hide comment
@tonybaloney

tonybaloney Dec 23, 2015

Contributor

done

Contributor

tonybaloney commented Dec 23, 2015

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment