Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t2.nano instance for ec2 #663

Closed

Conversation

@tonybaloney
Copy link
Contributor

tonybaloney commented Dec 21, 2015

No description provided.

@asfgit asfgit closed this in f856da9 Dec 21, 2015
@Kami
Copy link
Member

Kami commented Dec 22, 2015

I just noticed you didn't update region details dict - https://github.com/DimensionDataCBUSydney/libcloud/blob/1273eacf5a89547354ececf447a7684b0db38f2a/libcloud/compute/drivers/ec2.py#L647

If you don't update that, user won't be able to use this new instance type (size). You need to update region details entry for each region where this instance type is now available (you will also need to update affected tests).

@Kami
Copy link
Member

Kami commented Dec 22, 2015

And when you make that change, please also update changelog.

@tonybaloney
Copy link
Contributor Author

tonybaloney commented Dec 23, 2015

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.