[google compute] Add support for subnetworks #780
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool. I really wish we could find someone who would be willing to finish this - #345 Then we would also have a standard API for managing networks... :) |
|
|
||
| if 'items' in response: | ||
| if region is None: | ||
| for v in response['items'].values(): |
There was a problem hiding this comment.
That's quite some levels of nesting, would probably make it a bit easier to rid if this functionality was refactored in a separate method.
In any case, not a blocker for me.
|
Merged with 3246566 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Adding support subnetworks to GCE driver
Description
This PR adds support Google Compute Engine's subnetworks feature[1]. When this feature was introduced, Google suggested users begin using automatically allocated regional subnetworks versus a single global network. The GCE driver predates subnetworks, so the default is still set to create legacy networks, even though this is no longer recommended.
Subnetworks are a necessary prerequisite for other GCE networking features that will be added to libcloud shortly.
[1] https://cloud.google.com/compute/docs/subnetworks
Status
I intend to leave this PR open for community review for 7 days and will merge it to trunk if there are no outstanding issues on 10-May-2016.
Checklist (tick everything that applies)