Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[google compute] Add support for subnetworks #780

wants to merge 1 commit into from


Copy link

@erjohnso erjohnso commented May 3, 2016

Adding support subnetworks to GCE driver


This PR adds support Google Compute Engine's subnetworks feature[1]. When this feature was introduced, Google suggested users begin using automatically allocated regional subnetworks versus a single global network. The GCE driver predates subnetworks, so the default is still set to create legacy networks, even though this is no longer recommended.

Subnetworks are a necessary prerequisite for other GCE networking features that will be added to libcloud shortly.



I intend to leave this PR open for community review for 7 days and will merge it to trunk if there are no outstanding issues on 10-May-2016.

  • done, ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)

Copy link

Kami commented May 7, 2016


I really wish we could find someone who would be willing to finish this - #345

Then we would also have a standard API for managing networks... :)

if 'items' in response:
if region is None:
for v in response['items'].values():
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's quite some levels of nesting, would probably make it a bit easier to rid if this functionality was refactored in a separate method.

In any case, not a blocker for me.

Copy link
Member Author

erjohnso commented May 7, 2016

Merged with 3246566

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants