Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[google compute] Add support for subnetworks #780
Conversation
|
Cool. I really wish we could find someone who would be willing to finish this - #345 Then we would also have a standard API for managing networks... :) |
|
|
||
| if 'items' in response: | ||
| if region is None: | ||
| for v in response['items'].values(): |
Kami
May 7, 2016
Member
That's quite some levels of nesting, would probably make it a bit easier to rid if this functionality was refactored in a separate method.
In any case, not a blocker for me.
That's quite some levels of nesting, would probably make it a bit easier to rid if this functionality was refactored in a separate method.
In any case, not a blocker for me.
| if not region: | ||
| raise ValueError("Must provide a region for the subnetwork.") | ||
| else: | ||
| if isinstance(region, GCERegion): |
Kami
May 7, 2016
Member
Refactoring this region related functionality in a separate utility method would be nice.
Again not a blocker right now, but it would be great we at least have tests for all those various ways you can pass region in (if there aren't any already) so we can easily refactor it later on.
Refactoring this region related functionality in a separate utility method would be nice.
Again not a blocker right now, but it would be great we at least have tests for all those various ways you can pass region in (if there aren't any already) so we can easily refactor it later on.
erjohnso
May 7, 2016
Author
Member
Thanks for the review @Kami. Yes, I put in quite a few tests for this already, so should be fairly easy to refactor down the road.
Thanks for the review @Kami. Yes, I put in quite a few tests for this already, so should be fairly easy to refactor down the road.
|
Merged with 3246566 |
Adding support subnetworks to GCE driver
Description
This PR adds support Google Compute Engine's subnetworks feature[1]. When this feature was introduced, Google suggested users begin using automatically allocated regional subnetworks versus a single global network. The GCE driver predates subnetworks, so the default is still set to create legacy networks, even though this is no longer recommended.
Subnetworks are a necessary prerequisite for other GCE networking features that will be added to libcloud shortly.
[1] https://cloud.google.com/compute/docs/subnetworks
Status
I intend to leave this PR open for community review for 7 days and will merge it to trunk if there are no outstanding issues on 10-May-2016.
Checklist (tick everything that applies)