Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] engine version support hyphen #4246

Merged
merged 6 commits into from
Feb 21, 2023

Conversation

GuoPhilipse
Copy link
Member

What is the purpose of the change

currently if engine version contains hyphen ,for example:hive 1.1.0-cdh5.12.0
we will get enginetype as hive and version as 1.1.0 in enginetypelabel, we may improve it.

Related issues/PRs

Related issues: #4245
Related pr:#4246

Brief change log

  • overwrite setStringValue, allow hyphen to be included in engine version
  • test case added

Checklist

  • I have read the Contributing Guidelines on pull requests.
  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the Linkis mailing list first)
  • If this is a code change: I have written unit tests to fully verify the new behavior.

@GuoPhilipse GuoPhilipse changed the title [Bugfix]enginetype label support hyphen [Bugfix]engine version support hyphen Feb 20, 2023
@GuoPhilipse GuoPhilipse changed the title [Bugfix]engine version support hyphen [wip]engine version support hyphen Feb 21, 2023
@GuoPhilipse GuoPhilipse changed the title [wip]engine version support hyphen [Bugfix] engine version support hyphen Feb 21, 2023
@peacewong peacewong changed the base branch from dev-1.3.2 to dev-1.3.3 February 21, 2023 11:29
@peacewong peacewong merged commit 436f90d into apache:dev-1.3.3 Feb 21, 2023
@GuoPhilipse GuoPhilipse deleted the improveenginetypelabel branch February 22, 2023 15:46
GuoPhilipse added a commit to GuoPhilipse/incubator-linkis that referenced this pull request Mar 20, 2023
jackxu2011 pushed a commit that referenced this pull request Mar 21, 2023
* backport hive compatibility #4255 #4246 #4341 to 1.3.2

* trigger rebuild
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants