Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] support different hive version #4255

Merged
merged 3 commits into from
Feb 23, 2023
Merged

[feat] support different hive version #4255

merged 3 commits into from
Feb 23, 2023

Conversation

GuoPhilipse
Copy link
Member

What is the purpose of the change

add support for different hive version, for cdh version specially, we will no need to comment some code ,for this code is not fit for all hive version(cdh,hdp,apache)

Related issues/PRs

Related issues: #4254
Related pr:#4255

Brief change log

  • modify CustomerDelimitedJSONSerDe.java to fit for different hive version
  • change hive vesion properties for common use

Checklist

  • I have read the Contributing Guidelines on pull requests.
  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the Linkis mailing list first)
  • If this is a code change: I have written unit tests to fully verify the new behavior.

@GuoPhilipse GuoPhilipse changed the title [feat] support different hive version [wip] support different hive version Feb 22, 2023
@GuoPhilipse GuoPhilipse changed the title [wip] support different hive version [feat] support different hive version Feb 22, 2023
jackxu2011
jackxu2011 requested changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@jackxu2011 jackxu2011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use log4j to log the exception

...hive/src/main/java/org/apache/linkis/engineplugin/hive/serde/CustomerDelimitedJSONSerDe.java Outdated Show resolved Hide resolved
peacewong
peacewong approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@peacewong peacewong merged commit ee29de9 into apache:dev-1.3.3 Feb 23, 2023
@GuoPhilipse GuoPhilipse deleted the supportdifferenthiveversion branch March 7, 2023 15:58
GuoPhilipse added a commit to GuoPhilipse/incubator-linkis that referenced this pull request Mar 20, 2023
@GuoPhilipse
backport hive compatibility apache#4255 apache#4246 apache#4341 to 1.3.2
2bb6a39
@GuoPhilipse GuoPhilipse mentioned this pull request Mar 20, 2023
Merged
7 tasks
jackxu2011 pushed a commit that referenced this pull request Mar 21, 2023
@GuoPhilipse
Backport hive compatibility to 1.3.2 (#4394)
bfee7f1 
* backport hive compatibility #4255 #4246 #4341 to 1.3.2

* trigger rebuild
@aiceflower aiceflower mentioned this pull request May 31, 2023
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackxu2011 jackxu2011 jackxu2011 requested changes

@peacewong peacewong peacewong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GuoPhilipse @jackxu2011 @peacewong