Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] improve decision logic in CustomerDelimitedJSONSerDe.java #4341

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

GuoPhilipse
Copy link
Member

What is the purpose of the change

1、throw exception ahead if catagory is not INTERVAL_YEAR_MONTH or INTERVAL_YEAR_MONTH to avoid further check
2、only matched and existed catagory need to do encodeBase64

Related issues/PRs

Related issues: #4340
Related pr:#4341

Brief change log

1、throw exception ahead if catagory is not INTERVAL_YEAR_MONTH or INTERVAL_YEAR_MONTH to avoid further check
2、only matched and existed catagory need to do encodeBase64

Checklist

  • I have read the Contributing Guidelines on pull requests.
  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the Linkis mailing list first)
  • If this is a code change: I have written unit tests to fully verify the new behavior.

Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@peacewong peacewong merged commit 72d8404 into apache:dev-1.4.0 Mar 8, 2023
@GuoPhilipse GuoPhilipse deleted the fixhiveserge branch March 10, 2023 14:03
GuoPhilipse added a commit to GuoPhilipse/incubator-linkis that referenced this pull request Mar 20, 2023
jackxu2011 pushed a commit that referenced this pull request Mar 21, 2023
* backport hive compatibility #4255 #4246 #4341 to 1.3.2

* trigger rebuild
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants