Remove obsolete properties, methods, and classes for 3.0 #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ormattter serialize-deserialze testing across versions, and correct serialization property bag names broken by modernization (apache#124).
|
For #125 |
erikmav
changed the base branch from
master
to
Feature/111-Dropping-support-for-older-runtimes
FreeAndNil
reviewed
Apr 3, 2024
There was a problem hiding this comment.
Thanks a lot.
Just one question.
I've noted the breaking changes in #125 (comment)
FreeAndNil
force-pushed
the
Feature/111-Dropping-support-for-older-runtimes
branch
from
7e93b50
to
6d23e81
Compare
FreeAndNil
merged commit 202bb5c
into
apache:Feature/111-Dropping-support-for-older-runtimes
|
@erikmav because of https://learn.microsoft.com/en-us/dotnet/standard/serialization/binaryformatter-security-guide we think about removing ISerializable and [Serializable] (at least for netstandard). |
|
Unneeded by me. During the 3.0 work it was not clear that serialization could be removed, so I added the newer extensive unit tests including ensuring back compat. Removing it along with all the tests is fine by me.
…________________________________
From: Jan Friedrich ***@***.***>
Sent: Thursday, September 5, 2024 3:29 PM
To: apache/logging-log4net ***@***.***>
Cc: Erik Mavrinac ***@***.***>; Mention ***@***.***>
Subject: Re: [apache/logging-log4net] Remove obsolete properties, methods, and classes for 3.0 (PR #138)
@erikmav<https://github.com/erikmav> because of https://learn.microsoft.com/en-us/dotnet/standard/serialization/binaryformatter-security-guide we think about removing ISerializable and [Serializable] (at least for netstandard).
What do you think?
Where are you using this serialization for log4net objects?
—
Reply to this email directly, view it on GitHub<#138 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAHYCQQIPR2XEAPCGCLDYDLZVDLLLAVCNFSM6AAAAABFNMA7OKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZSG4ZTSNJUGE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
@erikmav thanks for your feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add BinaryFormattter serialize-deserialze testing across versions, and correct serialization property bag names broken by modernization (#124).
Commented out obsolete tag for FixFlags.Mdc as the obsolete tags in MDC.cs are commented out.