LUCENE-9134: Port ant-regenerate tasks to Gradle build #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 20 commits
January 17, 2020 18:54
This reverts commit 28c4921
This reverts commit be939ff
Squashed commit of the following: commit 4b5105e Author: Robert Muir <rmuir@apache.org> Date: Thu Jan 30 08:26:26 2020 -0500 LUCENE-9193: heap allocations for tests.profile Can be a bit noisier than cpu sampling, due to how threads are allocated in tests... maybe we can improve that in the future. commit 3a8ed5e Author: Dawid Weiss <dweiss@apache.org> Date: Thu Jan 30 13:45:15 2020 +0100 LUCENE-9134: add python-based regeneration of HTMLCharacterEntities.jflex inside jflexHTMLStripCharFilter. commit 043dd20 Author: Dawid Weiss <dweiss@apache.org> Date: Thu Jan 30 12:50:50 2020 +0100 LUCENE-9080: this jflex file got corrupted somehow during previous commit. I regenerated it with ant, along with the final java file. I also added a crlf normalization, encoding and forced-regeneration to ant because it didn't work before. commit 13e2094 Author: Adrien Grand <jpountz@gmail.com> Date: Thu Jan 30 10:37:39 2020 +0100 LUCENE-4702: Improve performance for fuzzy queries. Fuzzy queries with an edit distance of 1 or 2 must visit all blocks whose prefix length is 1 or 2. By not compressing those, we can trade very little space (a couple MBs in the case of the wikibigall index) for better query efficiency. commit a948291 Author: Ignacio Vera <ivera@apache.org> Date: Thu Jan 30 08:03:22 2020 +0100 LUCENE-9141: Simplify LatLonShapeXQuery API by adding a new abstract class called LatLonGeometry. (#1170)
madrob
reviewed
Feb 10, 2020
lucene/core/src/java/org/apache/lucene/util/automaton/createLevAutomata.py
Outdated
Show resolved
Hide resolved
|
I made the changes Mike mentioned, but I won't create another PR for a bit to give others a chance to look |
madrob
reviewed
Feb 11, 2020
madrob
approved these changes
Feb 11, 2020
…packed regeneration)
|
New PR momentarily. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the generation targets for util/packed and util/automaton.
For whatever reason my local Python doesn't do anything weird like it did when regenerating the html entities, the generated code is identical.
One thing I'd like to draw attention to is that I had to change createLevAutomata.py to path to the new place moman is downloaded to.
I'll merge upstream in the next day or two barring objections.
I think this finishes off the regeneration work, so I'll close LUCENE-9134 after merging.