SOLR-14471: properly apply base replica ordering to last-place shards… #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….preference matches
tflobbe
approved these changes
May 14, 2020
| // Add a PULL replica so that there's a tie for "last place" | ||
| replicas.add( | ||
| new Replica( | ||
| "node4", |
There was a problem hiding this comment.
Ah yes; fixed, thanks for catching that!
tflobbe
pushed a commit
that referenced
this pull request
May 15, 2020
Properly apply base replica ordering to last-place shards.preference matches
tflobbe
pushed a commit
to tflobbe/lucene-solr-1
that referenced
this pull request
May 16, 2020
…che#1507) Properly apply base replica ordering to last-place shards.preference matches
megancarey
pushed a commit
to megancarey/lucene-solr
that referenced
this pull request
May 18, 2020
…che#1507) Properly apply base replica ordering to last-place shards.preference matches
sigram
pushed a commit
to lucidworks/lucene-solr
that referenced
this pull request
Oct 21, 2020
…che#1507) Properly apply base replica ordering to last-place shards.preference matches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
….preference matches